This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Support Laravel v9 + Github Actions #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryental
approved these changes
Feb 17, 2022
|
Thanks for looking into this. I'm not sure why the tests didn't run for this PR, maybe you have to enable something. You can find the tests results at https://github.com/alecpl/laravel-swoole/actions/runs/1860568484. |
|
any news about merge it? |
|
Please merge this if possible. We are getting problems now because no lumen 9.x support :( |
|
Need merge 😢 |
|
@alecpl That's really cool bro! Really thank you for doing that. Sorry for my late reply here for all of you, I'm not in the best times... Anyway, I'll merge it, tks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that Travis tests aren't working. So, I configured Github Actions. Some tests are failing, but I hope this will help you to add Laravel v9 support. It looks that only one more test is failing with v9.
I'm unfortunately not familiar with this codebase so can't really fix these issues.