Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to launch gpsd_client #51

Closed
felixdivo opened this issue Nov 8, 2021 · 5 comments
Closed

How to launch gpsd_client #51

felixdivo opened this issue Nov 8, 2021 · 5 comments

Comments

@felixdivo
Copy link

This one is hopefully easy to solve: How can one launch gpsd_client? We are on foxy @ Ubuntu 20.04. What I did:

  • Install gps_umd and gpsd_client via rosdep
  • ros2 run gpsd_client gpsd_client -> No executable found
  • ros2 launch our.launch.yaml (see below) -> long stack trace and eventually: launch.substitutions.substitution_failure.SubstitutionFailure: package 'gpsd_client' found at '/opt/ros/foxy', but libexec directory '/opt/ros/foxy/lib/gpsd_client' does not exist

Am I missing something abvious? The readme does not mention the node name so maybe that's just what is wrong.

The file our.launch.yaml is very short:

launch:
  - node:
      pkg: gpsd_client
      exec: gpsd_client
      name: gpsd_client_node
@SivertHavso
Copy link

No nodes (executables) are compiled for gpsd_client. You'll have to load it as a component, gpsd_client::GPSDClientComponent. I'm not sure how ComposableNode can be used with .yaml launch files.

However, because this function:

void step()
{
#if GPSD_API_MAJOR_VERSION >= 5
if (!gps_->waiting(1e6))
return;
gps_data_t* p = gps_->read();
#else
gps_data_t *p = gps->poll();
#endif
process_data(p);
}

is not called anywhere, nothing will actually be published. You'll have to build gpsd_client with the changes in #46 to be able to use gpsd_client in ros2.

This is also related to issue #30

@felixdivo
Copy link
Author

Thanks @SivertHavso!

Well, I thought this would be simpler. 😅 But okay, now I get what's up with this and can probably get to run it. however, this should really by part of the distribution of the package.

@danthony06
Copy link
Collaborator

Okay, the #46 has been merged now.

@felixdivo
Copy link
Author

Thank you @danthony06! Looking forward to the next release.

@felixdivo
Copy link
Author

@danthony06 Are there plans for releasing the current version to Rolling and the upcoming Humble Hawksbill? Would be nice to use the new changes. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants