Fix for publishing Heading2 and DualAntennaHeading information #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 682a50d.
|
@msmcconnell: Since you originally added the Heading2/DualAntennaHeading messages, could you check and see if these changes work for you? |
|
Can handle both binary and ASCII logs now |
(cherry picked from commit 9fae071)
|
@pjreed I'm happy to test it but it will be a few days before I can get around to it. |
|
@pjreed I have tested these changes and confirmed they are working. @sharvil-patankar It looks like there is a merge conflict that needs to be fixed before this can be merged. |
|
Resolved merge conflicts |
sharvil-patankar
added a commit
to sharvil-patankar/novatel_gps_driver
that referenced
this pull request
Oct 14, 2019
Fix for publishing Heading2 and DualAntennaHeading information (swri-robotics#57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53