Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LanguageClient definition #56

Merged
merged 4 commits into from
Apr 23, 2023
Merged

Update LanguageClient definition #56

merged 4 commits into from
Apr 23, 2023

Conversation

alcarney
Copy link
Member

  • Helper methods like client.completion_request(uri, line, char) have been dropped, maintaining these would be too time consuming.
  • However the renamed initialize_session and shutdown_session methods remain.
  • The language client now exposes both sync and async versions of LSP methods to closer align with the client in Add a LanguageClient autogenerated from lsprotocol type definitions openlawlibrary/pygls#328, with the ultimate goal of removing pytest_lsp/gen.py in favour of the upstream client when it is available.

alcarney added 4 commits April 6, 2023 19:07
@alcarney
pytest-lsp: Update client
e2a3374 
- Update `scripts/gen_client.py` to align closer to what
  will (hopefully) be available in upstream pygls at some point.
- Drop most helper methods from `LanguageClient`
@alcarney
pytest-lsp: Update tests and examples to align with client methods
ad109d1
@alcarney
pytest-lsp: Add simple Makefile
8f426ca
@alcarney
pytest-lsp: Update documentation
7624e48
@alcarney alcarney merged commit b95c36e into swyddfa:develop Apr 23, 2023
@alcarney alcarney deleted the checks branch April 23, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alcarney