-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IWYU #6164
Remove IWYU #6164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for doing this :D
Umm GCC is unhappy and I'm not really sure why... Edit: Oh I think it's the PCH. |
I agree, it looks like the PCH didn't rebuild properly for some reason, but I don't see an obvious cause. Otherwise, this looks good. |
Let's see if a rebase fixes things. Edit: Sad...it did not... |
My guess is you've hit some inconsistency in how ccache and gcc (for pragma once) decide that a header is unchanged. Try making some change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's compiling now.
@wthrowe @nilsdeppe clang-tidy timed out because there were too many changed files, however, I noticed we were only running it on 1 core, so I added a commit to run it on 4 cores and we'll see if that helps. Otherwise just a rebase. Edit: Looks like clang tidy still failed. This time I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop the commit that crashed clang-tidy. I'm not worried about the timeout on a PR like this.
Proposed changes
This never really worked that well for us and we've had it disabled for a while now. I don't think we'll be trying to revive it again so I'm just removing it.
Upgrade instructions
Removed include-what-you-use (IWYU) as a dependency.
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments