Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IWYU #6164

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Remove IWYU #6164

merged 1 commit into from
Jul 26, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jul 19, 2024

Proposed changes

This never really worked that well for us and we've had it disabled for a while now. I don't think we'll be trying to revive it again so I'm just removing it.

Upgrade instructions

Removed include-what-you-use (IWYU) as a dependency.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

nilsdeppe
nilsdeppe previously approved these changes Jul 19, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for doing this :D

@knelli2
Copy link
Contributor Author

knelli2 commented Jul 19, 2024

Umm GCC is unhappy and I'm not really sure why...

Edit: Oh I think it's the PCH.

@wthrowe
Copy link
Member

wthrowe commented Jul 19, 2024

I agree, it looks like the PCH didn't rebuild properly for some reason, but I don't see an obvious cause.

Otherwise, this looks good.

@knelli2
Copy link
Contributor Author

knelli2 commented Jul 19, 2024

Let's see if a rebase fixes things.

Edit: Sad...it did not...

@wthrowe
Copy link
Member

wthrowe commented Jul 19, 2024

My guess is you've hit some inconsistency in how ccache and gcc (for pragma once) decide that a header is unchanged. Try making some change to TMPL.hpp that isn't just comments or add a blank line or something to change line numbers.

wthrowe
wthrowe previously approved these changes Jul 19, 2024
Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's compiling now.

@knelli2
Copy link
Contributor Author

knelli2 commented Jul 22, 2024

@wthrowe @nilsdeppe clang-tidy timed out because there were too many changed files, however, I noticed we were only running it on 1 core, so I added a commit to run it on 4 cores and we'll see if that helps. Otherwise just a rebase.

Edit: Looks like clang tidy still failed. This time I think -j4 caused it to run out of memory with so many files.

nilsdeppe
nilsdeppe previously approved these changes Jul 22, 2024
Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the commit that crashed clang-tidy. I'm not worried about the timeout on a PR like this.

@wthrowe wthrowe merged commit f728c6c into sxs-collaboration:develop Jul 26, 2024
19 of 22 checks passed
@nilsvu nilsvu added the build system CMake build system label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants