Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move registration to before import initial data in GhValenciaDivClean. #6173

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

ctrandrsn
Copy link
Contributor

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@ctrandrsn ctrandrsn requested a review from nilsdeppe July 22, 2024 14:44
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@knelli2 knelli2 merged commit 1c92996 into sxs-collaboration:develop Jul 25, 2024
22 checks passed
@nilsvu nilsvu changed the title Move registraion to before import initial data in GhValenciaDivClean. Move registration to before import initial data in GhValenciaDivClean. Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants