Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support case insensitive special keys in keymappings #1082

Merged
merged 3 commits into from
May 27, 2024

Conversation

mikavilpas
Copy link
Contributor

This enables mapping "<right>" instead of the current behavior, which requires "<Right>" and silently ignores the mapping in lowercase.

@mikavilpas
Copy link
Contributor Author

Forgot to add that case insensitive mappings are the default in vim, which has very similar syntax.

This enables mapping `"<right>"` instead of the current behavior, which
requires `"<Right>"` and silently ignores the mapping in lowercase.
@mikavilpas mikavilpas force-pushed the case-insensitive-keymapping-syntax branch from e2503c1 to a6d1383 Compare May 25, 2024 15:44
@sxyazi
Copy link
Owner

sxyazi commented May 27, 2024

The new code looks fine, I'll test it later and then merge it

Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sxyazi sxyazi merged commit 4c46862 into sxyazi:main May 27, 2024
6 checks passed
@mikavilpas mikavilpas deleted the case-insensitive-keymapping-syntax branch May 27, 2024 11:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants