Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add automatic nightly builds to the Github Actions workflow #1397

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

uznog
Copy link
Contributor

@uznog uznog commented Aug 2, 2024

Named after and hopefully resolving #1382

Changes include:

  • workflow running at a cron schedule (12:00 AM / 00:00 UTC)
  • workflow scheduled by cron runs nightly job, generating a pre-release

Nightly build name is yazi-nightly-<timestamp>. Flow tested with dummy artifact created:
https://github.com/uznog/yazi/actions/runs/10215675482

And here's the resulting pre-release: https://github.com/uznog/yazi/releases/tag/yazi-nightly-20240802-1236

@uncenter
Copy link
Contributor

uncenter commented Aug 2, 2024

If I'm reading this right, this creates a new nightly release every day? I think creating a single nightly-tagged rolling release might be better 🤔 , though I might not be understanding exactly what this is trying to solve.

@uznog
Copy link
Contributor Author

uznog commented Aug 2, 2024

I totally agree. I pushed a commit changing tag name to be a static nightly, which will work as the latest version built off master branch every day

@sxyazi
Copy link
Owner

sxyazi commented Aug 3, 2024

Thanks for the PR!

Could you also add a build time to the release body? Something like:

From commit: d2ebadb
Generated on: 2024-08-04 23:00:00 UTC

@uznog
Copy link
Contributor Author

uznog commented Aug 5, 2024

I guess this does the job:
https://github.com/uznog/yazi/releases/tag/nightly

@uncenter
Copy link
Contributor

uncenter commented Aug 5, 2024

Looks great!

Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sxyazi sxyazi merged commit 705196a into sxyazi:main Aug 6, 2024
6 checks passed
sxyazi added a commit that referenced this pull request Aug 7, 2024
sxyazi added a commit that referenced this pull request Aug 7, 2024
@sxyazi sxyazi changed the title feat: Add automatic nightly builds to the Github Actions workflow ci: add automatic nightly builds to the Github Actions workflow Aug 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants