Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: destructure tuples to enhance readability #1874

Merged
merged 1 commit into from
Nov 3, 2024
Merged

refactor: destructure tuples to enhance readability #1874

merged 1 commit into from
Nov 3, 2024

Conversation

Integral-Tech
Copy link
Contributor

No description provided.

sxyazi
sxyazi reviewed Nov 1, 2024
View reviewed changes
yazi-adapter/src/image.rs Outdated Show resolved Hide resolved
sxyazi
sxyazi reviewed Nov 1, 2024
View reviewed changes
yazi-adapter/src/kgp.rs Outdated Show resolved Hide resolved
sxyazi
sxyazi reviewed Nov 1, 2024
View reviewed changes
yazi-fm/src/signals.rs Outdated Show resolved Hide resolved
@Integral-Tech
Copy link
Contributor Author

@sxyazi All suggestions fixed :)

sxyazi
sxyazi requested changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks great overall!

I have two small change requests:

yazi-fm/src/signals.rs Outdated Show resolved Hide resolved
yazi-plugin/src/elements/gauge.rs Outdated Show resolved Hide resolved
@Integral-Tech Integral-Tech requested a review from sxyazi November 3, 2024 07:34
@Integral-Tech
Copy link
Contributor Author

Thanks, it looks great overall!

I have two small change requests:

Change requests fixed :)

sxyazi
sxyazi approved these changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! These refactors are stunning I can't lie :D

@sxyazi sxyazi merged commit 441ebcb into sxyazi:main Nov 3, 2024
6 checks passed
@Integral-Tech Integral-Tech deleted the destruct-tuple branch November 3, 2024 07:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sxyazi sxyazi sxyazi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integral-Tech @sxyazi