Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new scrolloff option to [manager] #679

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

dedukun
Copy link
Contributor

@dedukun dedukun commented Feb 14, 2024

This fixes #675

I've made like in neovim where if the scrolloff is a large numbe, like e.g. 200, the cursor will stay in the middle of the window.

@sxyazi
Copy link
Owner

sxyazi commented Feb 15, 2024

Thank you for the PR!

@sxyazi
Copy link
Owner

sxyazi commented Feb 15, 2024

Hi, I made some simplifications, would you like to give it a review?

Copy link
Contributor Author

@dedukun dedukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it look much better that way, it shows my lack of experience in rust 😅

@sxyazi
Copy link
Owner

sxyazi commented Feb 15, 2024

Thank you so much for contributing to this feature!

Let's merge it then

@sxyazi sxyazi merged commit b55c5dc into sxyazi:main Feb 15, 2024
5 checks passed
@sxyazi sxyazi changed the title feat: add scrolloff in [manager] feat: add new scrolloff option to [manager] Feb 15, 2024
@dedukun dedukun deleted the scrolloff branch February 15, 2024 11:25
@dedukun
Copy link
Contributor Author

dedukun commented Feb 15, 2024

If you want I can also make a PR in the docs

@sxyazi
Copy link
Owner

sxyazi commented Feb 15, 2024

If you want I can also make a PR in the docs

That's great, please do it!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new scrolloff option to [manager] in the yazi.toml
2 participants