[T-6490][17.0][ADD] crm_lead_attach_related_saleorder_report #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luis-ron
approved these changes
Sep 9, 2024
manuelregidor
requested changes
Sep 9, 2024
crm_lead_attach_related_saleorder_report/models/mail_compose_message.py
Outdated
Show resolved
Hide resolved
crm_lead_attach_related_saleorder_report/models/mail_compose_message.py
Outdated
Show resolved
Hide resolved
Tisho99
commented
Sep 9, 2024
crm_lead_attach_related_saleorder_report/models/mail_compose_message.py
Outdated
Show resolved
Hide resolved
|
I resolved all requested changes. Do i need to add tests? |
|
@Tisho99 As far as I know, all the modules in Sygel repositories must have tests from now on, so please, add them (unless @ValentinVinagre says the opposite). |
Tisho99
force-pushed
the
17.0-T-6490
branch
3 times, most recently
from
e82cf4a to
b045ddf
Compare
Tisho99
force-pushed
the
17.0-T-6490
branch
from
b045ddf to
52e4ffc
Compare
|
@Tisho99 do test's please 💘 . correct @manuelregidor 😄 |
manuelregidor
approved these changes
Sep 10, 2024
I think that to be on the safe side it wouldn't be a bad idea to review it again. |
|
@luis-ron u could review again please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.