[T-6536][15.0][ADD]transfer_client_portfolio, transfer_client_portfolio_commissions: Add new modules

[RogerSans]

This module allows to transfer contacts, activities and opportunities from one user to another.

The pre-commit error are caused by other modules

T-6536

@HaraldPanten
@ValentinVinagre
@luis-ron

[luis-ron]

Functional Review: LGTM 👍🏻

[Tisho99]

@manuelregidor Can you review?

[manuelregidor]

@Tisho99 Pre-commit is failing. Please, let me know when it's fixed and I'll do the technical review. And do you think it is necessary to have three commits?

[Tisho99]

@manuelregidor None of the pre-commit errors are due to my module, in that case the PR can be approbed, right?

[manuelregidor]

Just two small comments. No need to make changes if you don't think you need to.

[manuelregidor]

LGTM

[ValentinVinagre]

@Tisho99 Would it take you a long time to fix the bugs indicated in the pre-commit?

[ValentinVinagre]

fix pre-commit

[Tisho99]

@Tisho99 Would it take you a long time to fix the bugs indicated in the pre-commit?

1 hour more or less, there are a lot of errors

[Tisho99]

Hi @ValentinVinagre @manuelregidor

I have fixed pre-commit.

However, i am not sure if the following fix is correct:

Pre-commit told me i have to delete the cr.commit() and refactor the code if it was necessary to do the deletion.

I have only deleted the cr.commit() because the write above should update the database.

What do you think?

[manuelregidor]

@Tisho99 I don't think the write method writes on the database straightaway, but only after the transactions has finished. If there was an error, all the write operations performed before would be discarded, as the update query would not be triggered.

[ValentinVinagre]

Hi @ValentinVinagre @manuelregidor

I have fixed pre-commit.

However, i am not sure if the following fix is correct:

Pre-commit told me i have to delete the cr.commit() and refactor the code if it was necessary to do the deletion.

I have only deleted the cr.commit() because the write above should update the database.

What do you think?

cr.commit() was performed because:

• the changes are needed in the next iteration.
• you can't wait for the system to do the save, as it takes too long.
  It's necessary to perform a cr.commit(), which will make the pre-commit skip that point.

[Tisho99]

@ValentinVinagre

I have put again the cr.commit and skipped the pre-commit error.

This can be merged.

You have the activity in T-6536

[ValentinVinagre]

LGTM 👍🏻