Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about too old Emacs #1481

Closed
miikka opened this issue May 4, 2015 · 5 comments
Closed

Warn about too old Emacs #1481

miikka opened this issue May 4, 2015 · 5 comments

Comments

@miikka
Copy link

miikka commented May 4, 2015

How about showing a message if the Emacs version is too old for Spacemacs?

I just tried to install Spacemacs on Emacs 23.3.1, started Emacs and nothing happened. Took me a while to figure out what's going on. Doing nothing is nicer than getting mysterious error messages that backwards-incompability would surely cause, but it'd be even nicer to get a simple message that tells me what's wrong.

@tshemeng
Copy link
Contributor

tshemeng commented May 4, 2015

good idea

(when (version< emacs-version  "24.4")
  (message "emacs too old"))

@calebmeyer
Copy link

I don't mind PRing this change (assuming the code above isn't pseudocode), but I don't know where it should live.

@StreakyCobra
Copy link
Contributor

@calebmeyer In init.el there is already a check for this with a when. This when could probably be changed to an if, and in the else clause, display a message to say emacs is to old.

@Immortalin
Copy link
Contributor

@StreakyCobra @syl20bnr merge pull request and add fixed in develop label?

@AdrieanKhisbe
Copy link
Contributor

(@Immortalin: just made a comment on the commit about formating :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants