Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete command broken after org-present #2117

Closed
meditans opened this issue Jun 25, 2015 · 9 comments
Closed

Delete command broken after org-present #2117

meditans opened this issue Jun 25, 2015 · 9 comments

Comments

@meditans
Copy link

Hi, I found the d key doesn't work anymore after quitting anorg-present presentation.

To reproduce this bug:
0) Install the org layer

  1. Create a .org file
  2. M-x org-present
  3. exit with q
  4. try to use dd to delete a line
@swaroopch
Copy link
Contributor

This is rather strange because we don't override the d key at all.

Please see https://github.com/syl20bnr/spacemacs/blob/develop/contrib/org/packages.el#L158

Is the buffer left in buffer-read-only mode?

@meditans
Copy link
Author

Yeah, I never enter in write mode while in org-present.
The exact error is d is undefined. To be fair, the problem is not limited to the d key. I have the same problem with y or p. The movement keys seem to work, however.

@swaroopch
Copy link
Contributor

I can reproduce the problem. The worst part is that even i becomes undefined, so you can't go from normal mode to insert mode.

@swaroopch
Copy link
Contributor

Interestingly, if I comment out these two lines, things work as expected:

      ;; (add-hook 'org-present-mode-hook 'spacemacs//org-present-start)
      ;; (add-hook 'org-present-mode-quit-hook 'spacemacs//org-present-end)

So I'm guessing the problem has to do something with (evil-evilified-state) and (evil-normal-state).

@meditans Can you confirm that the behavior is normal when you comment out those two above lines in contrib/org/packages.el ?

@robbyoconnor
Copy link
Contributor

@syl20bnr, This is bad -- because i'm giving a talk trying to sell spacemacs and this glitch won't sell it well as I plan on demoing parts :-)

I can't enter insert mode -- I can force it into insert mode by calling evil-insert-state but I really don't wanna do that...

@robbyoconnor
Copy link
Contributor

Also none of the changes above fix the issue...I'm not sure what's causing the issue but I can't get any of the vim key bindings to work 😿

syl20bnr added a commit that referenced this issue Aug 12, 2015
@syl20bnr
Copy link
Owner

Should be fixed in develop.

@robbyoconnor
Copy link
Contributor

i still can't enter insert mode after exiting org-present

@syl20bnr
Copy link
Owner

@robbyoconnor You may have another issue, the fact that even the proposed fixes above did not work for you is weird.
I tried on several machines and this issue does not happen anymore.

bmag pushed a commit to bmag/spacemacs that referenced this issue Aug 13, 2015
@TheBB TheBB closed this as completed Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants