Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to disable company-mode in eshell? #2390

Closed
dzhwinter opened this issue Jul 24, 2015 · 7 comments
Closed

how to disable company-mode in eshell? #2390

dzhwinter opened this issue Jul 24, 2015 · 7 comments

Comments

@dzhwinter
Copy link

Of course, auto disable, not manual disable it after i open eshell.
i have try " (spacemacs|disable-company eshell-mode)" into my spacemacs file as doc says. not work.
And I have checked manual substitute the macro in core-auto-completion.el , still not work for me.

master branch up-to-date 0.103.2
emacs 24.5.1
ubuntu 14.04
Thank you

@zilongshanren
Copy link
Contributor

+1 for this issue, it's very annoying.

I have tried to add another hook to eshell-mode and manually call company-mode -1.

But I failed again...

@cpaulik
Copy link
Contributor

cpaulik commented Jul 24, 2015

I think this is difficult right now. It seems that company mode is enabled in the post-config part of use-package. see here. This means that it basically runs last. So any hook you add will be overridden. This might be a bug?

@person808
Copy link
Contributor

In dotspacemacs/config: (spacemacs|disable-company eshell-mode)

@cpaulik
Copy link
Contributor

cpaulik commented Jul 25, 2015

@person808 That works, thanks. @dzhwinter does it still not work for you?

@dzhwinter
Copy link
Author

@cpaulik.Thanks, but still not work for me. I tried his method when i first encountered this problem. I had check it a third time. In dotspacemacs/config: (spacemacs|disable-company eshell-mode)is useless. It is an instinct idea that disable company after load all the configuration. But We failed again and again, maybe the idle time is the stuff? see https://github.com/syl20bnr/spacemacs/blob/develop/contrib/shell/packages.el#L32

TheBB added a commit that referenced this issue Sep 14, 2015
Sets up company in eshell-mode-hook during the init phase so that it can
be reliably disabled in user config.
@TheBB
Copy link
Collaborator

TheBB commented Sep 14, 2015

@cpaulik is correct, the dotspacemacs/config function may run too soon. I confirmed the bug and moved the company hook sooner in the loading process so that it can now be disabled if you like.

dcluna pushed a commit to dcluna/spacemacs that referenced this issue Sep 14, 2015
Sets up company in eshell-mode-hook during the init phase so that it can
be reliably disabled in user config.
@dzhwinter
Copy link
Author

confirm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants