magit stages one line too many with evil-visual-line

[mbertheau]

In the magit status buffer when I want to stage a single line, if I mark it with V and then hit s to stage, the marked line and the next line get staged. You can see the region extend one line down after hitting s.

Workaround is to mark just one character in the line with v and stage then.

Now v is actually simpler than V, but V makes much more sense for staging a whole line.

[sooheon]

I think this may have something to do with the newline character being marked at the end of the line. With V you're selecting the entire line and the newline which begins the next line as well. I guess we can advice the magit state function, but like you said, just using v may be the simpler solution. FWIW, pure emacs users begin marking with C-SPC, and they don't have the linewise marking equivalent, hence the discrepancy.

[mbertheau]

There's a similar issue in magit-log, where I select commits with V in order to diff them with d d.

[syl20bnr]

I noticed this too and I use the same workaround with v instead of V, it is not really a big deal but it should be mentioned in the documentation.

[jb55]

This got me as well, I didn't realize you could use v until I read this issue.

[justbur]

Should be fixed with #3578