bookmark-default-file is defined differently in two different places #2594
Labels
Comments
|
I filed this because my bookmarks file was showing up in my recent file list and I was wondering why. It is partially due to the fact I have the spacemacs repo checked out to |
|
The configuration in |
travisbhartwell
added a commit
to travisbhartwell/spacemacs
that referenced
this issue
Aug 9, 2015
Only set `bookmark-default-file` in the package configuration. Put the file in the Spacemacs cache directory instead of the Emacs user directory. Also only set `bookmark-save-flag` in the package configuration. This is a breaking change. Those with existing bookmarks file will have to do something equivalent to this: `mv ~/.emacs.d/bookmarks ~/.emacs.d/.cache` and restart Emacs. Fixes syl20bnr#2594
syl20bnr
pushed a commit
that referenced
this issue
Aug 11, 2015
Only set `bookmark-default-file` in the package configuration. Put the file in the Spacemacs cache directory instead of the Emacs user directory. Also only set `bookmark-save-flag` in the package configuration. This is a breaking change. Those with existing bookmarks file will have to do something equivalent to this: `mv ~/.emacs.d/bookmarks ~/.emacs.d/.cache` and restart Emacs. Fixes #2594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bookmark-default-fileand its associatedbookmark-save-flagare set in two different places, and in the case ofbookmark-default-file, to two different values. I'm not seeing any bad behavior as such, but I noticed this when checking for something else.Linking to the most recent commit, they are in:
spacemacs/spacemacs/packages.el
Lines 431 to 433 in 88143a3
and
spacemacs/spacemacs/config.el
Lines 269 to 271 in 88143a3
I would offer a pull-request but I'm unsure which is the correct place to set it. I think putting it in the cache would be right.
The text was updated successfully, but these errors were encountered: