Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solarized themes are broken in 39f508a on develop #2628

Closed
robbyoconnor opened this issue Aug 12, 2015 · 2 comments
Closed

Solarized themes are broken in 39f508a on develop #2628

robbyoconnor opened this issue Aug 12, 2015 · 2 comments
Labels
Bug :-( Themes

Comments

@robbyoconnor
Copy link
Contributor

Commit 39f508a introduced a regression where my themes weren't loaded properly. I traced this by manually testing each of the newest commits pushed to develop.
@robbyoconnor robbyoconnor changed the title Themes are broken in 39f508a Themes are broken in 39f508a on develop Aug 12, 2015
@TheBB
Copy link
Collaborator

TheBB commented Aug 12, 2015

I traced this by manually testing each of the newest commits pushed to develop.

Just for the future, this is what git bisect optimises and partially automates for you. You give it a 'good' and a 'bad' commit and then it drops you off at various commits inbetween and you have to answer whether it's good or bad. After a while it tells you which commit is the first bad one. Binary search yo 👍

@TheBB
Copy link
Collaborator

TheBB commented Aug 12, 2015

Anyway, the bug is here.

robbyoconnor added a commit to robbyoconnor/spacemacs that referenced this issue Aug 12, 2015
@robbyoconnor
Fix the path for loading solarized.
c633dcf 
Closes syl20bnr#2628
@robbyoconnor robbyoconnor mentioned this issue Aug 12, 2015
Merged
robbyoconnor added a commit to robbyoconnor/spacemacs that referenced this issue Aug 12, 2015
@robbyoconnor
Fix the path for loading solarized.
cab9386 
Thanks to @TheBB for helping narrow this down!

Closes syl20bnr#2628
robbyoconnor added a commit to robbyoconnor/spacemacs that referenced this issue Aug 12, 2015
@robbyoconnor
Fix the path for loading solarized.
ba63987 
Once all extensions were moved from "extensions" to "local",
spacemacs was no longer able to find the solarized themes.

Thanks to @TheBB for helping narrow this down!

Closes syl20bnr#2628
@robbyoconnor robbyoconnor changed the title Themes are broken in 39f508a on develop Solarized themes are broken in 39f508a on develop Aug 12, 2015
bmag pushed a commit to bmag/spacemacs that referenced this issue Aug 13, 2015
@robbyoconnor
Fix the path for loading solarized.
9927d86 
Once all extensions were moved from "extensions" to "local",
spacemacs was no longer able to find the solarized themes.

Thanks to @TheBB for helping narrow this down!

Closes syl20bnr#2628
@TheBB TheBB closed this as completed Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug :-( Themes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robbyoconnor @TheBB @syl20bnr