Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up issues #2741

Closed
TheBB opened this issue Aug 24, 2015 · 12 comments
Closed

Cleaning up issues #2741

TheBB opened this issue Aug 24, 2015 · 12 comments

Comments

@TheBB
Copy link
Collaborator

TheBB commented Aug 24, 2015

Currently almost half the issues are still open. Many of them are labeled "fixed in develop" and will be closed on next release, but there are many others that in my opinion should be closed, not just bugs that are actually fixed but also questions and discussions that remain open long after they've been answered, discussed to death and/or abandoned.

I don't think this is ideal. It makes it difficult to get an overview.

I've looked through a few and found some candidates. I will update as I find more, and I invite everyone else with spare time to go treasure hunting.

For abandoned issues that we're not sure are fixed or not (the relevant code may have gone through heavy refactoring, or several versions of an upstream package have gone by since then, for example), it can be an option to close them with an invitation to reopen or re-report with fresh information if necessary.

Consider also whether it's worth to add a trusted collaborator or two with the go-ahead to do this for you, @syl20bnr. I know there's @trishume but he's now one of THEM not active at the moment.

@justbur
Copy link
Contributor

justbur commented Aug 24, 2015

@syl20bnr Would it be possible to give @TheBB the ability to do this himself? He seems pretty reasonable ;-)

@trishume
Copy link
Contributor

👍 for @TheBB replacing me as assistant Issue Traffic Controller.

@syl20bnr syl20bnr added this to the release 0.104 milestone Aug 25, 2015
@syl20bnr
Copy link
Owner

So @trishume has designated his successor, congratulations @TheBB !

@trishume Thank you for all the help and contributions you provided during the first year of Spacemacs. Special thanks for being the first contributor to the project 👍 I hope one day I'll be able to replace Spacemacs with your own editor ;-)

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 25, 2015

Thanks! I'll get to it momentarily.

@justbur
Copy link
Contributor

justbur commented Aug 25, 2015

Yes, @TheBB you're on the clock now. Unfortunately, we can't provide much in the way of benefits.

@cmccloud
Copy link
Contributor

A few more possibilities for your list.

#517 - discussion has run it's course
#563 - last updated > 6mo
#1357 - env issue?
#1505 - git-gutter no longer used
#1741 - git-gutter no longer used

@justbur
Copy link
Contributor

justbur commented Aug 28, 2015

@TheBB We should ask those people with lots of open issues to go through the old ones and close any that aren't relevant any more (they should be able to do this quicker than you or anyone else). I can't figure out how to find out who has the most issues open easily, but at least the people who actively contribute should be able to do this quickly. Just quickly going through it to find who has the most:

@tuhdo has 33
@xged 16
@tko 14
@cpaulik 11
@CestDiego 10
@geo7 10
@TheBB 9!!

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 28, 2015

Yes, good idea. I'll have you know that 4 of mine are due to be closed upon release and there's a PR open for the fifth. 😉

@geo7
Copy link
Contributor

geo7 commented Aug 28, 2015

is there a page where we can see all the issues we've made?

found it... at the top of ones github page

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 28, 2015

@justbur
Copy link
Contributor

justbur commented Aug 28, 2015

You can filter on author or click issues at the top of the page
On Fri, Aug 28, 2015 at 1:43 PM geo7 notifications@github.com wrote:

is there a page where we can see all the issues we've made?


Reply to this email directly or view it on GitHub
#2741 (comment)
.

@cpaulik
Copy link
Contributor

cpaulik commented Aug 28, 2015

Good idea. I've checked mine and was able to close some. For edge cases I pinged @TheBB and he can decide if they should be closed.

@TheBB TheBB closed this as completed Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants