Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magit-blame-mode interferes with linum-relative #341

Closed
bjarkevad opened this issue Dec 25, 2014 · 4 comments
Closed

magit-blame-mode interferes with linum-relative #341

bjarkevad opened this issue Dec 25, 2014 · 4 comments

Comments

@bjarkevad
Copy link
Contributor

When magit-blame-mode is active and linum-relative is enabled, relative line number do not reflect the correct amount of lines you'd need to jump to hit that line.

To reproduce:

  • Open a file currently under git source control
  • Press SPC g b to enable magit-blame-mode
  • Try to navigate around the file using both #{j,k} movements as well as press {j,k} multiple times
  • Observe that the number put in front of #{j,k} does not match the amount of keypresses needed when doing single movements {j,k}

I'm not sure if this is a bug in spacemacs, magit, linum, linum-relative or evil-mode, but I thought I'd put it here to shed some light on the issue.

@syl20bnr
Copy link
Owner

Even linum is buggy. It seems to be an issue to report to magit repository.

@syl20bnr
Copy link
Owner

syl20bnr commented Jan 3, 2015

@bjarkevad Did you report this issue in magit repo ?

@bjarkevad
Copy link
Contributor Author

I haven't no, been busy unfortunately :-)

On Sat, Jan 3, 2015, 08:22 Sylvain Benner notifications@github.com wrote:

@bjarkevad https://github.com/bjarkevad Did you report this issue in
magit repo ?


Reply to this email directly or view it on GitHub
#341 (comment).

@TheBB
Copy link
Collaborator

TheBB commented Feb 2, 2016

No movement on this in over a year, and nobody seems to want to report this upstream, so for now I will close this.

@TheBB TheBB closed this as completed Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants