Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacemacs-layouts: erc doesn't play well with layouts #4781

Closed
choppsv1 opened this issue Jan 24, 2016 · 5 comments
Closed

spacemacs-layouts: erc doesn't play well with layouts #4781

choppsv1 opened this issue Jan 24, 2016 · 5 comments

Comments

@choppsv1
Copy link
Contributor

When creating a layout and then opening an erc connection, the erc buffers land in the default layout and not in the currently viewed one.

@StreakyCobra
Copy link
Contributor

Related to #4517 probably.

@TheBB
Copy link
Collaborator

TheBB commented Jan 24, 2016

Er, we can do a bit better.

The buffers should be added to a named perspective. ERC in particular tends to open buffers at the most inconvenient times and the current persp might not be the ERC persp.

Secondly, the function should be added to erc-mode-hook and not erc-mode. o_O

@choppsv1
Copy link
Contributor Author

yes, the hook is wrong, but it's also only gets run if you open that defined layout. I define my own [i]rc layout. I think we need to be adding this hook somewhere else.

@choppsv1
Copy link
Contributor Author

IOW what TheBB said, plus add somewhere else :)

CestDiego added a commit to CestDiego/spacemacs that referenced this issue Jan 25, 2016
CestDiego added a commit to CestDiego/spacemacs that referenced this issue Jan 31, 2016
TheBB pushed a commit to TheBB/spacemacs that referenced this issue Feb 27, 2016
@TheBB TheBB mentioned this issue Feb 27, 2016
TheBB pushed a commit to TheBB/spacemacs that referenced this issue Mar 5, 2016
TheBB pushed a commit that referenced this issue Mar 12, 2016
@d12frosted
Copy link
Collaborator

Fixed with released of Spacemacs v0.200. Let us know if you still have any problems with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants