Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect indentation in haskell-mode #621

Closed
codygman opened this issue Feb 18, 2015 · 18 comments
Closed

Incorrect indentation in haskell-mode #621

codygman opened this issue Feb 18, 2015 · 18 comments
Labels
- Forum - Haskell Reported upstream stale marked as a stale issue/pr (usually by a bot)

Comments

@codygman
Copy link

test

I'm not sure if this is an error with hi2, if you need to modify behavior of evil-open-below in Haskell mode, or both. This is a vanilla Haskell mode install on nixos but I've also reproduced on a vanilla Ubuntu install.

@ocharles
Copy link
Contributor

I think this is a bug/something to be reported for hi2. I tend to agree, I find this behavior quite annoying, though I can see the sense in it...

@syl20bnr
Copy link
Owner

What's the status of this bug ?

@ocharles
Copy link
Contributor

I don't think it's a spacemacs bug - if anything it should be reported at https://github.com/haskell/haskell-mode

@ajnsit
Copy link
Contributor

ajnsit commented May 25, 2015

Is there a way to be certain if it's haskell-mode or spacemacs which has the bug? I see the same issue on a vanilla install of spacemacs on ubuntu. In fact the symptoms are much worse because a lot of times, the current line will also get automatically indented on pressing enter. But I don't see the same issue on vanilla emacs with haskell mode.

@codygman
Copy link
Author

Have you tried building from master? I think this fixed it:
2af7ea8
On May 25, 2015 12:17 PM, "Anupam Jain" notifications@github.com wrote:

Is there a way to be certain if it's haskell-mode or spacemacs which has
the bug? I see the same issue on a vanilla install of spacemacs on ubuntu.
In fact the symptoms are much worse because a lot of times, the current
line will also get automatically indented on pressing enter. But I don't
see the same issue on vanilla emacs with haskell mode.


Reply to this email directly or view it on GitHub
#621 (comment).

@PierreR
Copy link
Contributor

PierreR commented Jul 2, 2015

👍
I have found the behavior of evil-open-below quite counter-intuitive/annoying in general.
Is there an easy way to have the normal 'vim' behavior' (i + RET) back ?

@x-ji
Copy link
Contributor

x-ji commented Aug 11, 2015

Umm... evil-open-below is still exhibiting the same behavior if I do not enable structured-haskell-mode. However structured-haskell-mode seems to have issues with inserting brackets in INSERT state. It's quite annoying.

@TheBB
Copy link
Collaborator

TheBB commented Oct 19, 2015

@d12frosted And this...

@d12frosted
Copy link
Collaborator

Well, in haskell-indentation-mode (which is used in Spacemacs) behaviour is the same. The idea of using tab on region with this indentation mode enabled is that it allows you to move region left or right by pressing tab or S-tab repeatable without marking region again. Notice, what is written in echo area when you press = with active region. And looks like, we should mimic this behaviour somehow. When I try pressing = in normal state and then tab - nothing happens. When I press = again - region is not indented further. I am not sure how to mimic this thing, cause I don't use vim editing style.

But I don't see the same issue on vanilla emacs with haskell mode.

@ajnsit Have you enabled haskell-indentation-mode or turn-on-haskell-indentation before testing it?

@d12frosted
Copy link
Collaborator

@TheBB And here 😄

@TheBB TheBB added the Haskell label Oct 25, 2015
@d12frosted
Copy link
Collaborator

Oh, forgot to share this. 😄

@StreakyCobra
Copy link
Contributor

Any update on this issue?

@d12frosted
Copy link
Collaborator

@StreakyCobra see related PR (#3586).

But I believe that it's 'wontfix'.

@StreakyCobra
Copy link
Contributor

Oh, I didn't saw it, thx.

@StreakyCobra
Copy link
Contributor

Probably the same problem as in #5010. Problem with indentation has been reported upstream.

@d12frosted
Copy link
Collaborator

Upstream issue is not fixed yet.

Reference: haskell/haskell-mode#1265 (original report haskell/haskell-mode#896 was closed in favour of haskell/haskell-mode#1265).

@fiveNinePlusR
Copy link
Contributor

seems like this should be closed as it's an upstream issue.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Forum - Haskell Reported upstream stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

10 participants