Back to classic Solarized powerline, except better #1018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As of bbatsov/solarized-emacs#174 @ryanartecona's version looks much better so I retract my decision and think this should probably be feature gated. The question is if it should be the default or alternate. |
trishume
force-pushed
the
new-classic-powerline
branch
from
006a1e9
to
6e38e8f
Compare
|
I tried it and now I find the original spacemacs colors worst than the new ones -__________- |
|
Yah I am used to the new ones as well now :| Also bbatsov/solarized-emacs#174 should make it even better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more classic Spacemacs Powerline colours for Solarized Light. Unlike the old powerline this one does have better text contrast and no weird light grey empty bit. This change does not affect the new high-contrast powerline and only very subtly tweaks the look of the Solarized Dark powerline.
It's my personal belief that this does not need to be config variable gated but I'm open to it.
I personally can't see why anyone would want the super light version without contrasting sections, but it is highly subjective.
However I think @ryanartecona's high contrast light powerline looks pretty awesome so I left that in (see bbatsov/solarized-emacs#169). The dark powerline also looked fine as it is.
New but also old (this PR)
Old but also new (on develop as of 9885406)