Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README with some absolute paths #113

Closed
wants to merge 1 commit into from
Closed

Update the README with some absolute paths #113

wants to merge 1 commit into from

Conversation

whatyouhide
Copy link
Contributor

The "quick install" line used to suggest the user to git clone --recursive into .emacs.d. Perhaps is better to make the user clone in ~/.emacs.d so that they can install Spacemacs whatever their $(pwd) is.

I'm committing this since a couple of times I was frustrated that the Spacemacs installation didn't do anything just because I cloned .emacs.d somewhere other than ~.

The "quick install" line used to suggest the user to `git clone --recursive` into `.emacs.d`. Perhaps is better to make the user clone in `~/.emacs.d` so that they can install Spacemacs whatever their `$(pwd)` is.

I'm committing this since a couple of times I was frustrated that the Spacemacs installation didn't do anything just because I cloned `.emacs.d` somewhere other than `~`.
@syl20bnr
Copy link
Owner

Thank you for the PR.
Some advices regarding the PR:

  • you should create a branch per PR, for instance for this PR you could have created fix_absolute_path_readme. This is important because every subsequent commits you'll do on your PR branch (here master) will be added automatically to this PR.
  • the created branch should be forked from develop base branch instead of master.

More info: https://github.com/syl20bnr/spacemacs/blob/master/CONTRIBUTE.md

No need the create a new PR though, for this PR I have cherry-picked your commit into develop. It will be merged to master in the next release.

Thank you!

@syl20bnr syl20bnr closed this Nov 13, 2014
@whatyouhide
Copy link
Contributor Author

I committed and opened the PR kind in a hurry and didn't even read the CONTRIBUTE.md instructions. It won't happen again, sorry and thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants