Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #915] Change position of guide-key popup window #1387

Closed
wants to merge 1 commit into from
Closed

[Fix #915] Change position of guide-key popup window #1387

wants to merge 1 commit into from

Conversation

x-ji
Copy link
Contributor

@x-ji x-ji commented Apr 26, 2015

A fix for #915.

Previously situations like this would occur:

screenshot 2015-04-26 13 38 19

which makes it hard for new users to grasp what the commands are, if they vertically split windows.

Now at least they can all be displayed fully.

screenshot 2015-04-26 14 16 48

#1072 works fine for me. However if window-purpose is not to be incorporated soon, this could be a temporary fix?

…` in

  packages.el so that text can always be displayed fully
@CestDiego
Copy link
Contributor

This is very smat.... should be enough :)

@tuhdo
Copy link
Contributor

tuhdo commented Apr 26, 2015

I agree :)

@x-ji x-ji changed the title Change position of guide-key popup window [Fix #915] Change position of guide-key popup window Apr 27, 2015
@syl20bnr
Copy link
Owner

I wonder if we could use popwin with the same trick as helm.

@syl20bnr
Copy link
Owner

Thank you ! 👍
Will see what people say about this.
Cherry-picked into develop branch.

@syl20bnr syl20bnr closed this Apr 28, 2015
@mijoharas
Copy link
Contributor

Hmm... I'm not sure about this, with the previous guide-key you could use ? or C-h to discover the full names of the commands. However, you are right that new users would not know to do this, so this is probably more discoverable.

That aside, I think there is a bug because when I trigger guide-key, my current buffers get moved to the side (to allocate space for the side buffer that is no-longer there, I assume) and I find this somewhat jarring.

Otherwise, it probably does make sense, I'm probably just still used to the old way of doing it and haven't trained myself to look down rather than to the side yet. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants