In navigation layer, Bind J/K to scroll up/down in Info-mode #14188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smile13241324
requested changes
Dec 8, 2020
|
|
||
| | Key binding | Description | | ||
| |-------------+----------------------------| | ||
| | ~J~ | Scroll up (or next node) | |
There was a problem hiding this comment.
I think this should rather be moved into the documentation instead.
There was a problem hiding this comment.
Ah did not realize that. So I have updated the PR.
UNRELATED: wouldn't this new github feature be handy for Spacemacs development?
There was a problem hiding this comment.
Maybe lets discuss it in a separate issue 👍
Spacemacs lacks a keybinding alternative to the most natural way of scrolling Info pages (i.e. SPC) in vanilla emacs. Anyway, this commit adds J/K to scroll most naturally through info pages. Currently, in Info-mode, a keybinding for J is not defined while K is bound to evil-lookup. Issue syl20bnr#2828 already adresses the inconsistent experience, and in my opinion this can and should be improved as navigating Info pages is a very crucial part of using Emacs. Personally I have bound J/K to scroll page up/down in buffers/pdf/djvu/doc-view, which I inherited from using the zathura pdf reader, and I think this is a better default than the default vim alternatives.
dalanicolai
force-pushed
the
add_Info_mode_scroll_keybindings_to_navigation_layer
branch
from
e553c81 to
477bfbc
Compare
smile13241324
approved these changes
Dec 13, 2020
|
Thank you for contributing to spacemacs 💜, I have cherry picked your commit into develop. |
dalanicolai
added a commit
to dalanicolai/spacemacs
that referenced
this pull request
Dec 18, 2020
Similar to the keybindings added to the info layer in PR syl20bnr#14188, I here propose to add the same keybindings to the epub layer. These J/K keybindings are currently undefined in the epub layer. These keybindings are used in the Zathura document reader, they are very convenient and I guess they feel very natural and are preferred over d/u by most people.
smile13241324
pushed a commit
that referenced
this pull request
Dec 18, 2020
Similar to the keybindings added to the info layer in PR #14188, I here propose to add the same keybindings to the epub layer. These J/K keybindings are currently undefined in the epub layer. These keybindings are used in the Zathura document reader, they are very convenient and I guess they feel very natural and are preferred over d/u by most people.
dalanicolai
added a commit
to dalanicolai/spacemacs
that referenced
this pull request
Dec 19, 2020
Similar to the keybindings added to the info layer in PR syl20bnr#14188, I here propose to add the same keybindings to the epub layer. These J/K keybindings are currently undefined in the epub layer. These keybindings are used in the Zathura document reader, they are very convenient and I guess they feel very natural and are preferred over d/u by most people.
yyoncho
pushed a commit
to yyoncho/spacemacs
that referenced
this pull request
Jan 26, 2021
Similar to the keybindings added to the info layer in PR syl20bnr#14188, I here propose to add the same keybindings to the epub layer. These J/K keybindings are currently undefined in the epub layer. These keybindings are used in the Zathura document reader, they are very convenient and I guess they feel very natural and are preferred over d/u by most people.
adamczykm
pushed a commit
to adamczykm/spacemacs
that referenced
this pull request
Jan 28, 2021
Similar to the keybindings added to the info layer in PR syl20bnr#14188, I here propose to add the same keybindings to the epub layer. These J/K keybindings are currently undefined in the epub layer. These keybindings are used in the Zathura document reader, they are very convenient and I guess they feel very natural and are preferred over d/u by most people.
dalanicolai
deleted the
add_Info_mode_scroll_keybindings_to_navigation_layer
branch
aam-at
pushed a commit
to aam-at/spacemacs
that referenced
this pull request
Mar 23, 2021
Similar to the keybindings added to the info layer in PR syl20bnr#14188, I here propose to add the same keybindings to the epub layer. These J/K keybindings are currently undefined in the epub layer. These keybindings are used in the Zathura document reader, they are very convenient and I guess they feel very natural and are preferred over d/u by most people.
wang-d
pushed a commit
to wang-d/spacemacs
that referenced
this pull request
Jul 22, 2021
Similar to the keybindings added to the info layer in PR syl20bnr#14188, I here propose to add the same keybindings to the epub layer. These J/K keybindings are currently undefined in the epub layer. These keybindings are used in the Zathura document reader, they are very convenient and I guess they feel very natural and are preferred over d/u by most people.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spacemacs lacks a keybinding alternative to the most natural way of scrolling
Info pages (i.e. SPC) in vanilla Emacs.
This commit adds J/K to scroll most naturally through info pages.
Currently, in Info-mode, a keybinding for J is not defined while K is bound to
evil-lookup.
Issue #2828 already addresses the inconsistent experience, and in my opinion this
can and should be improved as navigating Info pages is a very crucial part of
using Emacs.
Personally I have bound J/K to scroll page up/down in buffers/pdf/djvu/doc-view,
which I inherited from using the zathura pdf reader, and I think this is a better
default than the default vim alternatives.