Add djvu layer #14920
Add djvu layer #14920
Conversation
dalanicolai
force-pushed
the
Add-djvu-layer
branch
3 times, most recently
from
73df8d8 to
20cb716
Compare
| @@ -0,0 +1,12 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
what's the license of this file
There was a problem hiding this comment.
The source is Wikipedia (https://commons.wikimedia.org/wiki/File:DjVu-logo.svg). From the permissions section, I guess we can safely use it here (even without acknowledging the source).
There was a problem hiding this comment.
okay. can you add a footnote to the image in README.org to explicitly mention the permission of usage.
This is not required in the past, but a few month ago we've discussed this in the maintainers channel.
There was a problem hiding this comment.
Well, I can add the source of the image (I guess as a caption?), but don't know about any explicit permission.
There was a problem hiding this comment.
"This logo image consists only of simple geometric shapes or text. It does not meet the threshold of originality needed for copyright protection, and is therefore in the public domain."
from commons.wkimedia.org
dalanicolai
force-pushed
the
Add-djvu-layer
branch
3 times, most recently
from
bed6296 to
6f2e7f3
Compare
|
Because I first accepted your 'suggestions' and did not pull them before implementing the other suggestions locally, I was fighting with git (I am still no expert). But I think that finally, all suggested changes have been 'implemented' correctly now. Anyway, thanks for the sharp and useful review! |
dalanicolai
force-pushed
the
Add-djvu-layer
branch
3 times, most recently
from
f7a7a6f to
3cc68d2
Compare
|
I got confused by cd0c943. It seems that when I accept your suggested changes here on github, an extra commit is created, which is undesirable of course. So I have reverted to a single commit and rebased on develop. |
dalanicolai
force-pushed
the
Add-djvu-layer
branch
from
3cc68d2 to
d429269
Compare
|
please check the remaining unresolved request. |
Update layers/+readers/djvu/packages.el Co-authored-by: Lucius Hu <1222865+lebensterben@users.noreply.github.com>
dalanicolai
force-pushed
the
Add-djvu-layer
branch
from
d429269 to
2e86f64
Compare
|
I have merged the PR and resolved the conflict in changelog.develop. I have also revised the layer and fixed the prefixes as well as the keybinding tables in the README. I have also removed the empty layer file for I did not see why a specific dependency on @dalanicolai care to double check? |
|
Thanks Maxi! I have looked at it and it all looks good to me. I don't remember why I added that dependency on |
This PR adds a djvu layer. Additional to the djvu package, the layer installs and configures the djvu3 (extension) package that adds many useful functionalities like rendering of annotations, a fast search and a djvu-occur search function, imenu navigation and more.