Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/comint keybindings #1759

Closed
wants to merge 3 commits into from
Closed

Feature/comint keybindings #1759

wants to merge 3 commits into from

Conversation

mijoharas
Copy link
Contributor

Sets up C-j and C-k for comint mode, also fixes a typo that meant the init-shell function wasn't being called (thanks @tuhdo). Fixes #586.

@mijoharas
Copy link
Contributor Author

Note, I only did this to fix shell-mode similar should be done for term and multi-term (I ran into some bugs and didn't have any more time to fix them).

@tuhdo
Copy link
Contributor

tuhdo commented May 28, 2015

C-j and C-k should be enabled when dotspacemacs-editing-style is equal to 'vim. Emacs users will be annoyed by such key bindings.

@mijoharas
Copy link
Contributor Author

good point @tuhdo (sorry, I need to think of the emacs-classic users more 😟 ). I'll push an update.

@mijoharas mijoharas force-pushed the feature/comint-keybindings branch from 5a19a09 to 509812c Compare May 28, 2015 18:07
@TheBB
Copy link
Contributor

TheBB commented Oct 22, 2015

@syl20bnr I was looking through old issues and found this. @mijoharas can you please rebase?

@TheBB
Copy link
Contributor

TheBB commented Oct 22, 2015

There are some modes that aren't derived from comint also which should be considered, eshell in particular.

@d12frosted d12frosted mentioned this pull request Nov 5, 2015
Closed
@TheBB
Copy link
Contributor

TheBB commented Nov 13, 2015

@mijoharas This PR is pretty old and has conflicts. Is it ok with you if I do a new version?

@mijoharas
Copy link
Contributor Author

@TheBB, that sounds great. Sorry I've been meaning to rebase this but have been kinda busy with work and so haven't found the time. Thanks!

@TheBB TheBB mentioned this pull request Nov 13, 2015
Closed
@TheBB
Copy link
Contributor

TheBB commented Nov 13, 2015

Continued in #3794.

@TheBB TheBB closed this Nov 13, 2015
@syl20bnr
Copy link
Owner

Thank you for your work @mijoharas and sorry for not having merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mijoharas @tuhdo @TheBB @syl20bnr