Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind <leader>msQ to restart Cider #2317

Closed
wants to merge 1 commit into from

Conversation

jcf
Copy link

@jcf jcf commented Jul 14, 2015

Sometimes restarting Cider is necessary, for example when you remove files that have already been used. As this seems like an extension of quitting Cider I've opted for SPC m s Q.

@StreakyCobra
Copy link
Contributor

@jcf Can you rebase your code on last develop branch, and also add the documentation of the new keybinding in the README?

Edit: I also notice you may want to bind this function in the cider-repl-mode.

@d12frosted
Copy link
Collaborator

@jcf ping. I would ask you to do the same thing that @StreakyCobra asked you :D And don't forget about #2313. Thanks 💃

@agzam
Copy link
Contributor

agzam commented Jun 16, 2016

Restarting CIDER used very rarely. I don't think we should be adding bindings for things that don't even have bindings natively (in their original packages). It's very easy to mistakenly tap on a wrong key. And restarting CIDER is an action that requires deliberate decisioning.

@syl20bnr
Copy link
Owner

That's OK we have plenty of room for key bindings, I may suggest SPC m s I (capital i) for restart if it is available. We can make it a convention for REPLs supporting this operation.

@lvh
Copy link

lvh commented Nov 25, 2016

I disagree that this is used rarely; I use it all the time for when dependencies are added. I formerly used this via bbatsov's prelude (Cider's author) via I think , in the REPL mode, which brings up a menu of cider-related options, including restart.

@TheBB
Copy link
Collaborator

TheBB commented May 30, 2017

Thanks! Cherry-picked in develop. You can safely delete your branch.

I moved it to SPC m s X.

@TheBB TheBB closed this May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants