-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included an option to skip loading helm at startup #2435
Conversation
I'm not sure this variable is necessary, you can add |
☝️ I agree with @syl20bnr here -- the less work to configure, the better.Helm is good. |
I understand this request might sound crazy to Linux users, where helm barely takes 1.5 seconds to load. It's intended for Windows users, where helm can add up to 25 seconds to the start up time and there is no real chance to use tricks like run emacs as a client. @robbyoconnor Helm is very good indeed! So good that I don't really want to remove it by adding it to Never the less, I appreciate that there are other issues more important than this, so I'm happy not pursuing this any further. Feel free to close my pull request if you don't find it useful. No worries :-) |
Ok I understand it better, what you want is to modify Here is an alternative: (use-package helm
:defer (if (system-is-mswindows) t 1)
... So on Windows helm will be loaded only when it is required but on other OSes it can also be loaded after 1 second of idle time. |
☝️ 👍 -- I like that. |
If it takes 25 sec to load helm something is wrong, even on windows. It takes my windows computer at most 1 sec. Also By the way emacs25 on windows now works in daemon mode. |
Windows is shit to begin with 👅 |
@justbur do you have an SSD? On my old Windows machine with 5400 RPM HDD, it takes that much amount of time to load Helm, and with Windows 25. On my MacBook, it takes 3 seconds to load everything with 25 layers. |
Oh but this varies since on another newer Windows machine it loads everything with only 6 seconds (still HDD). I guess the 5 years old Windows made the difference. |
In my Linux machine with very poor configuration (i3, 4gb RAM and 5400 RPM HDD), Helm takes +/- a minute to load which is very troublesome to me, especially since I love it! |
Are you using Arch Linux? If so, it is having this issue: emacs-helm/helm#1000. The fix is in that issue report. |
Wow, yes I am! Thanks! At least I know it's a bizarre problem with Tramp (although I've never used it) and that it should be fixed in newer versions. |
Yes my ssd probably makes a huge difference of course. I was just surprised I was trying to suggest looking into a specific cause like tramp or
|
@syl20bnr The code you suggested works better than mine (no surprises here). @justbur Helm's loading time varies in my computer. When I start my laptop early morning in the office, Helm loads in 5 modest seconds, but as the day goes on and I open more programs, it can be as slow as 25 seconds. I'm using a i3, 8 GB RAM laptop. It's not the software neither the hardware. It's obviously a Windows issue 😄
That doesn't really help. I'd like to use my Debian laptop at work but I can't. Thank you for contributing anyway 😉 |
I wonder if we could create a variable to specify a machine profile like -syl20bnr- On Tue, Jul 28, 2015 at 10:23 AM, RafaelGP notifications@github.com wrote:
|
I was thinking of something along the same lines actually. Even just On Tue, Jul 28, 2015 at 10:31 AM Sylvain Benner notifications@github.com
|
I have wondered this as well; with my two windows machine, helm takes between 5-10 sec to load according to use-package-verbose. Is there a command to run at startup to determine what is taking helm so long to load? |
Otherwise set ':defer 1'
At any rate, whatever we do, I do not think we will be merging this as is. Thank you for the contribution though. |
Helm is a fantastic package, but it's not for me. I don't really need 90% of all it can do.
Although I use other packages to replace the other10% (dired+, ibuffer, counsel, swipper, etc...) Spacemacs still loads helm at start up, which depending on the day, adds between 5 or 25 seconds to my emacs startup time (yep, I'm in windows).
So I created a new variable called dotspacemacs-load-helm to allow users skip loading helm at start up. I think it's fair offer users this choice and don't make compulsory load such a heavy package
PS: this is my first pull request ever. Apologies if I haven't done anything correctly.