Add mu4e layer

[darkfeline]

Branch for developing mu4e layer for Spacemacs.

[numkem]

I can vouch that it works without problems.

[myrjola]

Nice! 👍 Looking forward to get this merged.

[gabrielalmeida]

Great! Note that it breaks contrib/spotify which does use SPC m as group:music, bind should be remapped.

[darkfeline]

@gabrielalmeida Yuck. I think an email client should take priority over using Emacs to control Spotify. Let Spotify be SPC a M. Worst case I'll make mu4e take SPC a M, but given that Emacs is a text tool, mail should take priority over music.

Edit: I've changed mu4e to SPC a M. If/when this gets accepted I'll file a change request to swap the two.

[andreas-h]

+1

[syl20bnr]

Let Spotify be SPC a M

👍

[cmccloud]

Thanks for this. If there is any interest in adding some optional g-mail specific functionality to this layer, you can take a look at my config here: https://github.com/cmccloud/.spacemacs.d/blob/master/layers/mu4e/extensions.el

[darkfeline]

@cmccloud I will look into borrowing some of your code, or you can pull request if you want direct credit for it.

Just the extra evilify bindings for now. I don't need the extra Gmail features myself since I keep email simple (read, delete, save a copy in my org-mode notes if I need to keep it). If others want it then I will take it if they don't interfere with non-Gmail users.

Why do you use progn in use-package? :init and :config can take multiple expressions.

[syl20bnr]

Spacemacs uses progn also ;-)

more info here: #2255

I will add it to the conventions.

[syl20bnr]

Also I'm going to merge this soon so @cmccloud can add some config if he wants.

[cmccloud]

@darkfeline Feel free to borrow whatever you like. Honestly I think the best place for a lot of that code might be in the documentation as an example of how to add gmail specific functionality. On the other hand, none of the code will interfere with other mail services, but it may have funny behavior.

e.g. adding a /Trash tag instructs g-mail to move a message to the trash - most other services probably wont do that.

[cmccloud]

@darkfeline i've refactored my mu4e config to use the new packages.el features if you're interested in taking a look.
@syl20bnr please correct me if i've used these incorrectly, but they seem to work just fine

https://github.com/cmccloud/.spacemacs.d/blob/master/layers/mu4e/packages.el

[syl20bnr]

I highly suggest to suppress :step post, actually I may remove this keyword because it will harm more than it helps. Only the pre step is really useful for some important package that provide services useful for the other packages.

The packages are loaded in alphabetical order so the loading order is deterministic and easy to know in advance. So if A require B then we can use some eval-after-load black magic. Throwing post step in this will just remove the benefit of the deterministic loading behavior.

(EDIT: TL;DR we don't need :step post :-))

[boj]

👍

[nwolfe]

Ping @darkfeline

[cpaulik]

👍

When this is merged I can add a few nice features that I have collected. Like attaching files using helm.

[nwolfe]

There's a built-in function called mu4e-action-view-in-browser that does this

[darkfeline]

This should be mergeable as is. I'm a bit hesitant to add anything else since I only use basic email functionality, and I don't want to push any code I haven't tested personally.

@syl20bnr Please merge unless you have additional comments, the community can add more features as they see fit.

[nwolfe]

@darkfeline It seems like @syl20bnr was waiting for you to remove the :step post line? That's how I'm reading his comment at least 😃

Also, the directory structure for layers has changed since this PR was submitted. This layer should now be under layers/+email/mu4e.

This is awesome, looking forward to getting this merged in so the community can build this out further.

[darkfeline]

@nwolfe

Also, the directory structure for layers has changed since this PR was submitted. This layer should now be under layers/+email/mu4e.

Duh, I forgot about that.

It seems like @syl20bnr was waiting for you to remove the :step post line? That's how I'm reading his comment at least 

I don't think I've used :step post anywhere.

(As an aside/warning, I did a rebase/push --force, which is probably not recommended Git usage. The alternative would be to merge develop -> mu4e, but I didn't know if Github would then decide to include all 500+ of those commits into the PR as well. It looks like Github handled the forced rebase fairly cleanly?)

[nwolfe]

@darkfeline Awesome, thanks for updating. Yeah I don't know what the :step post stuff was about.

Shoot, I forgot to mention that @syl20bnr prefers PRs to be a single commit. Could you please squash these commits into one? That should be the last hurdle for merging/cherry-picking this in!

Your git moves are good; rebase is necessary and correct, and you'll have to push --force once you squash the commits locally.

[darkfeline]

@nwolfe Done.

[nwolfe]

👍

[nwolfe]

Bump - I believe this is ready for merge

[dsdshcym]

👍 for this layer. mu4e is way better than gnus.

[nwolfe]

@TheBB @syl20bnr Please merge

[TheBB]

Maybe this is a stupid question, but where is mu4e itself? It's listed in this PR as an extension, but the code for it is not included. I also can't find a package called mu4e on MELPA.

[cpaulik]

mu4e is installed when you install mu. Normally into /usr/share/emacs/site-lisp. The site-lisp path should normally be in the load-path.

[nwolfe]

The site-lisp path should normally be in the load-path.

That's an exercise left for the reader, right? Not something we can hard-code into this layer itself?

[cpaulik]

I don't know if the path to site-lisp is the same for all linux distributions and I have no idea if it is fixed on OSX or Windows (if mu works on those systems?)

[mclearc]

For OS X it is going to depend on whether the user is using stock emacs or emacs from hombrew. The latter has site-lisp in usr/local/share/emacs/

[nwolfe]

Yeah, not something we can hardcode then. Probably worthwhile to document in the README once this is merged though.

[d12frosted]

But then you should add a note in README about it.

[tsenart]

+1

[TheBB]

Thank you! Cherry-picked in develop. You can safely delete your branch. 🎉

I made some changes in 5f3793a:

• Clarified installation instructions (as per above discussion) and bring the README in line with the current documentation conventions.
• Added a layer variable for installation path instead of having the user mess with load-path in the init phase.
• Moved mu4e-account-alist to config.el where it belongs.
• Moved the main code to packages.el since extensions.el is now deprecated.
• Define the mu4e package as built-in and not as local.
• Auto-load mu4e on invocation of the two given keybindings, since prior to this it was not deferred.

I should note that I haven't used this layer so please, those of you who intend to use it let me know if I have messed something up. I will probably try it out in the future. :-)

[d12frosted]

Nice, mu4e is now part of Spacemacs. Going to try it.