Remove php-extras for now #2629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The php-extras package is not available on elpa. I suggest we remove it for now, and add it when/if its available on elpa. Closes syl20bnr#1986 syl20bnr#2503 syl20bnr#1314
|
Why not just comment it out with a note rather than outright delete it? |
|
Thank you ! Oh by the way, I just added support for quelpa: https://github.com/syl20bnr/spacemacs/blob/develop/contrib/!lang/php/packages.el#L21-L29 😸 |
|
@robbyoconnor Personally i dont like having commented out code in any production system. But I can make a new PR and add the extras package when its possible. 👍 |
|
It was just a suggestion -- heavy-handed but still a suggestion :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The php-extras package is not available on ELPA. I suggest we remove it
for now, and add it when/if its available on ELPA. I dont see php-mode getting merged to master when its not fully working. It also slows down Spacemacs startup. Closes #1986 #2503 #1314