-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added keybindings for slime-edit-definition* functions. #2648
Conversation
also remove now obsolete fix thanks to this new fix Fixes syl20bnr#2167 Fixes syl20bnr#2183 Fixes syl20bnr#2184
For Linux only uninstalling didn't do the job. I had to purge the package.
Calling `magit-blame-mode` directly is not advised as of Magit 2.1.0, and will leave a buffer in read-only mode upon exit. `magit-blame` also allows recursive blame upon repeated usage.
magit-log-all has the same with the old magit-log: show the commit log immediately without asking for revision. We should use magit-git-log for smoother transition to magit 2.1.
1. Fix broken links. 2. Make spacing consistent with other documentation. 3. Use a better function example. The previous one did not work for some common use cases. 4. Update and add some screenshots for use in the file.
dedicated modes for ClojureScript, ClojureC and ClojureX were introduced by clojure-emacs/clojure-mode@20356bc
GNU is having issues with HTTPS right now. Fixes syl20bnr#2596
|
||
| Key Binding | Description | | ||
|---------------------------+---------------------------------| | ||
| ~SPC m d d~ | Go to definition | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following CONVENTIONS.md file it should SPC m g g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, but SPC m g g is currently used for slime-inspect-definition.
Could move that to SPC m g i.
On Thu, Aug 13, 2015 at 7:27 PM, Sylvain Benner notifications@github.com
wrote:
In contrib/slime/README.org
#2648 (comment):@@ -74,6 +74,15 @@ of Common Lisp, you can specify it in your =~/.spacemacs=
|SPC m c f| Compile function |
|SPC m c r| Compile region |+** Definition
+
+| Key Binding | Description |
+|---------------------------+---------------------------------|
+|SPC m d d| Go to definition |following CONVENTIONS.md file it should SPC m g g
—
Reply to this email directly or view it on GitHub
https://github.com/syl20bnr/spacemacs/pull/2648/files#r37045468.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh... inspect definition ? what does it do exactly ? It may go under SPC m h i
if it only print some info.
[Doing some PR/issues cleanup] Is this PR still going to be accpeted? If no, can we close it? If yes, what modifications must be done to make it merge-able? :-) |
It has to be rebased at the very least. It would be best if this was done against develop. @BnMcGn? |
Ignorant git newbie here. What needs to be done? On Fri, Oct 30, 2015 at 2:43 AM, Eivind Fonn notifications@github.com
|
Hi there, this is against |
This should just be closed @BnMcGn -- click the button to do this. |
No description provided.