Properly initialize the display for daemon mode.

[travisbhartwell]

WORK IN PROGRESS. NEEDS TESTING. NEEDS TO USE THIS THROUGHOUT THE REST
OF SPACEMACS INITIALIZATION.

Will push a clean commit when everything is working satisfactorily.

Add macro to wrap things that depend on the display being
initialized (and a frame active), such as getting the font. Advise the
server-create-window-system-frame function which is called by
emacsclient when creating a window-system frame. This is only run the
first time a frame is created, so the advice removes itself.

Fixes: #299 and #1894
(Among others)

[syl20bnr]

For me it fixes the font issue, I could merge this if you are OK.

[travisbhartwell]

Sure, I just changed the commit message to remove to the WIP.

[TheBB]

So, do we do it then?

[jmingtan]

This fix works well for me, thank you

[rihenperry]

@TheBB why is this pull request still not merged into develop? closing this pull request will close many contingent issues.

[travisbhartwell]

I just rebased this onto develop as of today, so it should be even easier to apply. :)

[StreakyCobra]

I just tested it and it works 😄 If you have troubles to make it work (like me 😅), be sure to remove all compiled version (*.elc) of involved files.

[cpaulik]

I just ran into the problem and this fixed it. 👍

[cpaulik]

I wrote too soon. This only solves the font issue for the first frame I create. On subsequent frames the font is again too big as reported in #535

[travisbhartwell]

@cpaulik I just tested it again (after rebasing on current develop) and can't reproduce. I did SPC : describe-font RET RET on each frame I created to test, and each one showed the same results.

What I did:

1. Started Emacs in daemon mode with emacs --daemon
2. Launched a graphical frame with emacsclient -c
3. Opened another graphical frame with C-x 5 2.
4. Closed both of those frames.
5. Opened another graphical frame with emacsclient.
6. While that was still opened, opened a second frame from the command line with emacsclient.
   I am using the default Spacemacs font choice. In each frame in these above scenarios, I got the following from describe-font:

name (opened by): -adobe-Source Code Pro-normal-normal-normal-*-13-*-*-*-m-0-iso10646-1
       full name: Source Code Pro:pixelsize=13:foundry=adobe:weight=normal:slant=normal:width=normal:spacing=100:scalable=true
            size: 13
          height: 17
 baseline-offset:  0
relative-compose:  0

I am running on NixOS, with this patch rebased on the latest develop, in GNU Emacs 24.5.2.

I'd love to help track down why this isn't working for you to make this solution more robust so it can be merged. @cpaulik, could you tell me what steps you took to cause the issues with the incorrectly sized font? What platform are you on and which Emacs version? Are you using something other than the default font that is defined in the .spacemacs template? If so, I need to test against that and see why it's not working.

[cpaulik]

I've started again with an empty dotspacemacs file and can not reproduce my issue. I'll try to track it down.

[cpaulik]

I've narrowed the problem down to the sublime-themes package in the themes-megapack layer . If I exclude sublime-themes everything works as expected. But I was not able to find anything suspicious in sublime-themes

[CestDiego]

Is there any news regarding this one?

[syl20bnr]

I merged it!!! :-)
I had to make a fix which I hope won't break anything, see commit fa39bb1

Thank you 💯
Cherry-picked into develop branch, you can safely delete your branch.