Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame manipulation commands #2785

Closed

Conversation

oppenlander
Copy link
Contributor

Added commands for creating and switching around frames.

@robbyoconnor
Copy link
Contributor

👍 ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@syl20bnr
Copy link
Owner

That's great 👍
Can you try to make it work with helm ?

@oppenlander
Copy link
Contributor Author

@syl20bnr I'll look in to this.
It will probably involve creating a functions utilizing completing-read, which should automatically select between ido and helm.

@Kethku
Copy link
Contributor

Kethku commented Aug 31, 2015

I have also found frame-move to be greatly helpful. It makes it so that the window move commands move between frames if an error is thrown. This is brilliant for multi monitor setups because you don't have to use a separate command to switch between frames; you can just use the same evil-window-up etc.

Use this if you want to add this functionality. Seems to work very well on my machine but should be tested on macs/different versions.

(use-package framemove
  :init
  (setq framemove-hook-into-windmove t)))

Might be good to add to this PR, or I can make a new PR adding it. I don't know what the procedure is.

@oppenlander
Copy link
Contributor Author

@Devagamster I don't like it hooking in to windmove, but I do like the idea of including framemove.el for SPC F [hjkl].
Maybe compound this with documenting that (setq framemove-hook-into-windmove t) is available?

@Kethku
Copy link
Contributor

Kethku commented Aug 31, 2015

Sounds perfect 😄

@StreakyCobra
Copy link
Contributor

@oppenlander Can you rebase your work on develop ? :-)

@oppenlander
Copy link
Contributor Author

@StreakyCobra Sorry for the late reply.
I'm in the middle of a move, and don't have much time to work on this, but will get back to it when I can.

There is a bit more work to be done on this.
Right now IDO and Helm override certain built in functions, so we need to specially handle some of the manipulation commands.

@StreakyCobra
Copy link
Contributor

@oppenlander No worries, take your time, I'm just trying to resurrect/reanimate old interesting PR :-)

@shobute
Copy link

shobute commented Jan 31, 2017

Sorry for bumping an extremely old MR, but I'd love to see this functionality. Just wondering what additional work would be needed to get this in? I'd be happy to pick it up.

@robbyoconnor
Copy link
Contributor

Hey @shobute,

  1. Conflicts would need to be resolved.
  2. I'm not sure if @oppenlander was done yet...

@oppenlander
Copy link
Contributor Author

Go ahead and use the PR by @shobute
I never found the time to add the Helm/windmove commands.

@TheBB
Copy link
Collaborator

TheBB commented May 23, 2017

Closing in favour of #8302

@TheBB TheBB closed this May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants