Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure mode tweaks #2889

Closed
wants to merge 6 commits into from
Closed

Conversation

luxbock
Copy link

@luxbock luxbock commented Sep 4, 2015

No description provided.

@luxbock luxbock force-pushed the clojure-mode-tweaks branch from 9eb052c to 85c2b82 Compare September 4, 2015 18:08
@luxbock
Copy link
Author

luxbock commented Sep 4, 2015

I tried adding prefixes for the clj-refactor commands as well, but this made some of them stop working so I removed those. I also see some js2r prefixes among the cljr prefixes which is really weird and I couldn't figure out where they were coming from (this has been happening before as well, but I only tried looking for the reason now).

@justbur
Copy link
Contributor

justbur commented Sep 4, 2015

@luxbock I don't think the declare prefix for mode stuff is going to work 100% of the time until #2876 is merged. You can also now use which-key-declare-prefixes-for-mode directly if you like.

@luxbock
Copy link
Author

luxbock commented Sep 5, 2015

One thing that's also puzzling me is why the "J" key is not working in cider-stacktrace-mode-map, despite clearly being present there when I inspect the keymap object myself. Anyone have a clue?

luxbock added 3 commits September 5, 2015 20:03
- It doesn't do anything other than messing up the buffer.
- Gives faster access to display the last error buffer.
@luxbock luxbock force-pushed the clojure-mode-tweaks branch from 3593bfa to 2b86d55 Compare September 5, 2015 13:20
@sooheon
Copy link

sooheon commented Sep 6, 2015

What do you think of "msx" for cider-refresh, as I have in #2870? C-x is the default binding for it in cider, and the repl stuff should go under "ms".

@luxbock
Copy link
Author

luxbock commented Sep 6, 2015

Yeah I think that makes sense. Sorry for not having seen your PR! Not sure what the protocol is for situations like these. Should I remove that commit?

@sooheon
Copy link

sooheon commented Sep 6, 2015

Would be simpler if you squash the change onto here (with the rationale) and I just delete mine.

Speaking of which, I think syl20bnr prefers that all the commits in a PR be squashed together :)

@luxbock
Copy link
Author

luxbock commented Sep 7, 2015

Whops, wasn't quite in time! I'll remove the keybinding from this PR.

@luxbock
Copy link
Author

luxbock commented Sep 7, 2015

I think it's better to make small commits so that one can comment on them and easily change the ones that are not upto par, but I have no problem squashing them in the end when requested. If @syl20bnr would like me to just squash everything by default then that's fine as well of course.

@luxbock luxbock force-pushed the clojure-mode-tweaks branch from 6a4af2d to e8bd5cc Compare September 7, 2015 09:13
@syl20bnr
Copy link
Owner

Thank you !
Rebasing is not required, I can do it on my side. Actually most of the time I prefer rebasing myself :-)
@sooheon @luxbock Be sure to fix any conflict with some previous PRs because I merged it without looking at the issues you mentioned here.

Cherry-picked and squashed into develop branch, you can safely delete your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants