-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clojure mode tweaks #2889
Clojure mode tweaks #2889
Conversation
- Use cider-find-var instead.
9eb052c
to
85c2b82
Compare
I tried adding prefixes for the clj-refactor commands as well, but this made some of them stop working so I removed those. I also see some |
One thing that's also puzzling me is why the "J" key is not working in |
- It doesn't do anything other than messing up the buffer.
- Gives faster access to display the last error buffer.
3593bfa
to
2b86d55
Compare
What do you think of "msx" for cider-refresh, as I have in #2870? C-x is the default binding for it in cider, and the repl stuff should go under "ms". |
Yeah I think that makes sense. Sorry for not having seen your PR! Not sure what the protocol is for situations like these. Should I remove that commit? |
Would be simpler if you squash the change onto here (with the rationale) and I just delete mine. Speaking of which, I think syl20bnr prefers that all the commits in a PR be squashed together :) |
Whops, wasn't quite in time! I'll remove the keybinding from this PR. |
I think it's better to make small commits so that one can comment on them and easily change the ones that are not upto par, but I have no problem squashing them in the end when requested. If @syl20bnr would like me to just squash everything by default then that's fine as well of course. |
6a4af2d
to
e8bd5cc
Compare
Thank you ! Cherry-picked and squashed into develop branch, you can safely delete your branch. |
No description provided.