Adding rubocop to ruby layer

[dcluna]

rubocop is a useful lint tool and should have its place in Spacemacs.

[robbyoconnor]

Awhile ago I would have objected but this is handy...Flycheck can run rubocop for you _BUT_ this is handy for the autocorrect :D

[syl20bnr]

do we need the check commands ? Can flycheck do it automatically for us ?

[robbyoconnor]

I was opposed to #2362 on these grounds, but literally the only saving grace for this is the autocorrect functionality...I agree with @syl20bnr on this one...leave the autocorrect stuff though, that's handy.

[dcluna]

OK, should I remove these? How do I do it? Just push a new commit, send a new PR or something else?

[robbyoconnor]

Yes, commit and push to the same branch and then rebase (choose "fixup") -- your PR should be _ONE_ commit.

[dcluna]

Thanks, should be good to go now.

[robbyoconnor]

👍 ❤️

[robbyoconnor]

A quick git pull --rebase on this branch should bring it up to date with the current develop ;)

[nixmaniack]

Apart from rebase we will need hooks/keys for ruby-mode since we moved away from enh-ruby as default.

[robbyoconnor]

Apart from rebase we will need hooks/keys for ruby-mode since we moved away from enh-ruby as default.

yes, please do this @dcluna ;)

[syl20bnr]

Thank you 👍
I adapted it in commit 5b99a60 the main change is that RuboCop bindings are under SPC m r r.
Cherry-picked into develop branch, you can safely delete your branch.