Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magit-discard keybinding #3407

Closed
wants to merge 1 commit into from
Closed

Add magit-discard keybinding #3407

wants to merge 1 commit into from

Conversation

synic
Copy link
Contributor

@synic synic commented Oct 14, 2015

Fixes #3362

Not really sure if it needs to be bound everywhere like the other ones, but it seems to be working fine.

@TheBB
Copy link
Collaborator

TheBB commented Oct 15, 2015

Isn't this actually a bug in Evilify that should be fixed instead? Re: the discussion in #3362.

@synic
Copy link
Contributor Author

synic commented Oct 15, 2015

Ah, I will close this then.

@synic synic closed this Oct 15, 2015
@synic synic reopened this Oct 17, 2015
@syl20bnr
Copy link
Owner

I would like to investigate the issue before merging this, expect me to look at it pretty quickly.

@synic
Copy link
Contributor Author

synic commented Oct 19, 2015

Sounds like it's fixed!

@synic synic closed this Oct 19, 2015
@nixmaniack
Copy link
Contributor

Not yet for me. Tested on latest develop with updated packages after reading above comment.

@synic
Copy link
Contributor Author

synic commented Oct 19, 2015

Yeah, it seemed to work one for me, but now I'm getting magit-file-untrack again.

@synic synic reopened this Oct 19, 2015
@TheBB
Copy link
Collaborator

TheBB commented Oct 29, 2015

This is probably not needed any more after evil-magit?

@synic
Copy link
Contributor Author

synic commented Oct 29, 2015

Nope.

@synic synic closed this Oct 29, 2015
@TheBB
Copy link
Collaborator

TheBB commented Oct 29, 2015

Thank you anyway. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants