Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Factor out spacemacs-buffer creation #3426

Closed
wants to merge 3 commits into from
Closed

core: Factor out spacemacs-buffer creation #3426

wants to merge 3 commits into from

Conversation

justbur
Copy link
Contributor

@justbur justbur commented Oct 16, 2015

Factor out the code related to creating the spacemacs buffer, so that it
can be recreated easily if it gets deleted.

Completes @person808's work on #3357

@justbur
Copy link
Contributor Author

justbur commented Oct 16, 2015

The second commit might be controversial so I left it separated

@StreakyCobra
Copy link
Contributor

#3354

@syl20bnr
Copy link
Owner

syl20bnr commented Dec 1, 2015

@justbur I'm a bit late on this one, sorry to ask you this, but can you rebase it against last develop ?

Factor out the code related to creating the spacemacs buffer, so that it
can be recreated easily if it gets deleted.
The rationale is to keep the spacemacs buffer related code contained in
the core-spacemacs-buffer.el file.
@justbur
Copy link
Contributor Author

justbur commented Dec 1, 2015

@syl20bnr this is working now

@StreakyCobra
Copy link
Contributor

So you can probably bind (or modify) SPC b h (spacemacs/home) to spacemacs-buffer/goto-buffer directly.

@justbur
Copy link
Contributor Author

justbur commented Dec 1, 2015

I thought b h fit better with "home" that's why I kept it

@StreakyCobra
Copy link
Contributor

Yeah, but if the buffer *spacemacs* doesn't exist it should be recreated no?

Nevermind, I didn't scroll enough on the diff.

@justbur
Copy link
Contributor Author

justbur commented Dec 1, 2015

It is recreated here unless I'm misunderstanding you.
On Tue, Dec 1, 2015 at 2:31 PM Fabien Dubosson notifications@github.com
wrote:

Yeah, but if the buffer spacemacs doesn't exist it should be recreated
no?


Reply to this email directly or view it on GitHub
#3426 (comment).

@StreakyCobra
Copy link
Contributor

Everything is fine. I edited my previous message just after writing it, you probably didn't received the update by mail :-)

@syl20bnr
Copy link
Owner

Thank you 👍
I had some weird side effect like glitches and page-break that did not work anymore, I tried to fix them, I hope I did not break anything :-)
Cherry-picked in develop branch, you can safely delete your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants