-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Factor out spacemacs-buffer creation #3426
Conversation
The second commit might be controversial so I left it separated |
@justbur I'm a bit late on this one, sorry to ask you this, but can you rebase it against last develop ? |
Factor out the code related to creating the spacemacs buffer, so that it can be recreated easily if it gets deleted.
The rationale is to keep the spacemacs buffer related code contained in the core-spacemacs-buffer.el file.
@syl20bnr this is working now |
So you can probably bind (or modify) |
I thought |
Nevermind, I didn't scroll enough on the diff. |
It is recreated here unless I'm misunderstanding you.
|
Everything is fine. I edited my previous message just after writing it, you probably didn't received the update by mail :-) |
Thank you 👍 |
Factor out the code related to creating the spacemacs buffer, so that it
can be recreated easily if it gets deleted.
Completes @person808's work on #3357