Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

holy-mode: Assume we are always in emacs state #3497

Closed
wants to merge 2 commits into from
Closed

holy-mode: Assume we are always in emacs state #3497

wants to merge 2 commits into from

Commits on Oct 21, 2015

  1. holy-mode: Simplify implementation 

    The variable `evil-buffer-regexps` overrides setting the initial evil
state based on mode, so all we do now is to set all buffers' initial
states to emacs using this variable. This avoids having to manage the
mode-specific state variables in evil.
    @justbur
    justbur committed Oct 21, 2015
    Configuration menu
    Copy the full SHA
    f03feec View commit details
    Browse the repository at this point in the history

  2. holy-mode: Disable ESC key binding by default 

    We should not assume that users of holy mode are aware of evil and
normal state. Users were accidentally escaping into normal state with
ESC under the old implementation and didn't know how to return given
that they assumed they were only using emacs key bindings.

Fixes #3495, #3473 and #3453.

Introduce a new variable `holy-mode-allow-esc-to-normal-state` to allow
for the old behavior if users want to set this explicitly.
    @justbur
    justbur committed Oct 21, 2015
    Configuration menu
    Copy the full SHA
    7e56696 View commit details
    Browse the repository at this point in the history