Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured haskell/init-haskell-mode settings #3524

Closed
wants to merge 1 commit into from

Conversation

taksuyu
Copy link
Contributor

@taksuyu taksuyu commented Oct 23, 2015

Followed suggestions in #3488

@d12frosted
Copy link
Contributor

How does it play when you change those variables in user-config function?

P. S. Sorry, can't test it right now - gonna play with it tomorrow 😄

@taksuyu
Copy link
Contributor Author

taksuyu commented Oct 23, 2015

So far I've tested with haskell-stylish-on-save; a simple (setq haskell-stylish-on-save t) within dotspacemacs/config works, and describe-variable properly reports that the variable is set to t and the default is nil when in haskell-mode.

When it was in :config trying to change haskell-stylish-on-save through emacs customization or dotspacemacs/config made no difference, unless I reloaded my spacemacs config while already in haskell-mode.

@d12frosted
Copy link
Contributor

Great. Played with it a bit - works like a charm.

@syl20bnr thanks for this idea! Much easier to change configs.

@taksuyu
Copy link
Contributor Author

taksuyu commented Nov 7, 2015

Looks like there is some other stuff that got pushed, want me to bring the branch up to date?

@d12frosted
Copy link
Contributor

@TheBB any chances that it gets merged?

@StreakyCobra
Copy link
Contributor

This PR should probably be rebased to have more chances being merged. Then try to ping TheBB 😉

@taksuyu taksuyu force-pushed the haskell/init-haskell-mode branch from fc71db7 to c73f7fb Compare November 10, 2015 18:27
@taksuyu
Copy link
Contributor Author

taksuyu commented Nov 10, 2015

@TheBB Branch has been rebased to match with develop.

@TheBB TheBB added the Reviewed label Nov 10, 2015
@TheBB
Copy link
Contributor

TheBB commented Nov 10, 2015

Looks good. Labeling this so I don't forget.

@TheBB
Copy link
Contributor

TheBB commented Nov 10, 2015

I didn't have to remember for long.

Thanks! Cherry-picked in develop. You can safely delete your branch.

@TheBB TheBB closed this Nov 10, 2015
@taksuyu taksuyu deleted the haskell/init-haskell-mode branch November 10, 2015 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants