Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linum toggle local and add a variable for global mode #3557

Closed
wants to merge 1 commit into from

Conversation

StreakyCobra
Copy link
Contributor

global-linum-mode is making line numbers appearing in *spacemacs*
and helm buffers, what is annoying.

This change make the linum SPC t n toggle buffer-local, and add a
customization variable in .spacemacs to enable line numbers globally.
«Globally» here as to be understood as «in prog-mode and text-mode».


#+begin_src emacs-lisp
(setq-default dotspacemacs-global-line-numbers t)
#+end_src
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify that this belongs in dotpspacemacs/user-config 😛

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also read:

Line numbers can be toggled on in all =prog-mode= and =text-mode= buffers by setting the...

`global-linum-mode` is making line numbers appearing in `*spacemacs*`
and `helm` buffers, what is annoying.

This change make the linum `SPC t n` toggle buffer-local, and add a
customization variable in `.spacemacs` to enable line numbers globally.
«Globally» here as to be understood as «in `prog-mode` and `text-mode`».
@StreakyCobra
Copy link
Contributor Author

@robbyoconnor I added the buffers word, but didn't specify the dotpspacemacs/user-config information as it shouldn't be placed there. It will be in dotspacemacs/init, and I copied the information message from similar variable smooth-scrolling, so it should be fine.

@TheBB Thx for the tip, updated :-)

@robbyoconnor
Copy link
Contributor

@StreakyCobra ah :)

@TheBB
Copy link
Collaborator

TheBB commented Oct 29, 2015

Thank you! Love it 👍 Cherry-picked in develop. You can safely delete your branch.

@TheBB TheBB closed this Oct 29, 2015
@StreakyCobra StreakyCobra deleted the feature/linum branch October 29, 2015 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants