Helm-spacemacs facelift #3769
Merged
Helm-spacemacs facelift #3769
+37
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the keybindings didn't work exactly as planned. Gimme a sec... |
TheBB
force-pushed
the
beautify-helm-spacemacs
branch
from
351e380 to
a991927
Compare
|
There, that's better. :-) |
|
⚡ Realtime fixes 🐛 🔫 Very nice, I like it 👍 This is like night and day, the current sources make my eyes bleed now 😭 |
|
Thank you for this..I'll inspect your code to see how to define faces in helm :D |
|
@TheBB also, how do you have your helm thing on the minibuffer (bottom) and not on the top? D: |
|
@CestDiego Set For the faces I just propertize the strings in the source definitions. |
|
@TheBB thanks :D now sweetgreen.el looks way prettier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some faces. Also show leader keybinding for toggles, and I reversed the order for packages (the leftmost thing should be what you are primarily searching for). This means that the packages are not ordered by layer any more, but I think it's okay like this. I also refactored the FAQ source a bit since some of the lines were getting long.
The light blue you're seeing is
font-lock-type-faceand the dark gray isfont-lock-doc-face. For the keybindings I went with thehelm-M-xstandard key face. I can change this of course if it turns out that these are terrible choices for some themes. We could also define our own faces.