Add keys to browse back and forward in help-mode

[AdrieanKhisbe]

Implemented #2698

and + follow symbol with s

[StreakyCobra]

Maybe using (also) n and N, and/or u and d can be useful here? Not sure though.

[AdrieanKhisbe]

@StreakyCobra u and d are undefined.what do you want me to bind them to? :)

N/n are already bind to evil-search-next

[StreakyCobra]

I was thinking that, as people are used to C-u and C-d to scroll, u (up) and d (down) would be kind of mnemonics. But I just tried and C-u and C-d are working so, it may not be necessary at all to add bindings?

On the other hand if we really want single-key scrolling, f, b, n and N are already used by evil, so it may be wise to use u and d instead of f and b. When in help buffers, I sometime want to select region (to copy/paste for instance) and using b to go to previous word, or f to find a symbol, are quite useful. So what do you think of using u and d instead, as:

• d is not useful because help buffers are read-only so it's not possible to delete line; and
• u for the same reason as there is nothing to undo because of read-only?

Retracted

[TheBB]

These functions don't scroll, they go back and forward between pages, like in a browser.

[TheBB]

In info the ] and [ keys go forward and back. I like those.

[StreakyCobra]

Yeah, as I said in my previous (wrong) comment, I use f and b sometimes and I'm probably not the only one, so it may be wise to find better bindings.

[AdrieanKhisbe]

I mean keys

[StreakyCobra]

I'm not sure f and b should be used as the override some useful evil bindings, @TheBB What do you think?

u and d are fine for me. I can live with C-u and C-d only though.

[AdrieanKhisbe]

@StreakyCobra I didn't touch to f and b for these reasons

[StreakyCobra]

You are adding f and b here no? Or did i missed something?

[AdrieanKhisbe]

Well, forgot I made a mistake as it seems: cf the comment :D

[StreakyCobra]

But now n is also used by evil for searching 😜

Simply keep [ and ] for sure, and s, u and d if you think they are useful ☺️

[AdrieanKhisbe]

indeed. ^^

[AdrieanKhisbe]

modified and accordingly, and squashed commit

[StreakyCobra]

👍

[AdrieanKhisbe]

:)

[syl20bnr]

I'm not sure we need u and d, there is already C-u and C-d which are consistent accross Emacs. I find it not really useful to create a specificity in help mode.
Follow-symbol should be on mhh (major-mode binding) to be consistent with the conventions, s is useful for people using evil-sniper.
Also for forward and back I propose the additional gf and gb.

[AdrieanKhisbe]

@syl20bnr Applied your recommandations :)
(I still have to lean vim conventions :D)

[syl20bnr]

Thank you 👍
I replaced mhh by gh and added the documentation where I could, see commit 5895e0e
Cherry-picked into develop branch, you can safely delete your branch.

[AdrieanKhisbe]

@syl20bnr great :)