-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global access to all available REPLs #4600
Add global access to all available REPLs #4600
Conversation
@@ -11,6 +11,8 @@ | |||
|
|||
(defvar configuration-layer--protected-packages) | |||
(defvar dotspacemacs-filepath) | |||
(defvar spacemacs-repl-list '() | |||
"Registered REPLs to run from ~SPC a r~.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the mention to the key binding.
"List of all registered REPLs" is sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, done.
What about |
What about More seriously:
but we need the opinion of other people anyway I think. |
That sounds good and mnemonic. Let some other people show their opinion :P. Btw, how to set a prefix binding? |
spacemacs/layers/+distribution/spacemacs-base/config.el Lines 17 to 68 in 8adb066
|
or |
I see, when other people show themselves we'll add it. So far, |
|
Oh god, |
Oh, I shouldn't have been on the correct project when I searched for it 😔 |
Are we okay with |
I have to think about it, |
I'll add it tomorrow then ;). |
If this is okay as it is, i'll rebase it. |
Enable a global binding to access a list of available REPLs to run everywhere. If the requested REPL depends on a major-mode that hasn't been loaded, it will be loaded along its dependencies. To make this work, a new `spacemacs/register-repl` function is included. This function adds a major-mode and its repl function to a global variable.
Everything rebased and ready to go! |
Thanks! Cherry-picked in develop. You can safely delete your branch. I cleaned your code up a bit in e8a10c3. In particular, calling a major mode function is a poor way of loading a file, just call In bedf807 I fixed the ielm code (which wasn't up to scratch) and registered it as a REPL, and I also did the shells in 44fd52d. That's a good start. |
Oh, and I changed the binding to |
Enable a global binding to access a list of available REPLs to run everywhere. If the requested REPL depends on a major-mode that hasn't been loaded, it will be loaded along its dependencies. The global binding is under
SPC a R
.To make this work, a new
spacemacs/register-repl
function is included. This function adds a major-mode and its repl function to a global variable.Further work, such as add every layer REPL to this list is due to be completed after this PR is eviewed, to avoid silly work.
Address #3395