Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] change OS X installation instructions #5161

Closed
wants to merge 1 commit into from

Conversation

d12frosted
Copy link
Contributor

So not it's recommended to install GNU emacs instead of emacs-mac as
discussed in #4955.


Not sure what to do with these notes in FAQ.

P. S. I will remove WIP once we decide what to do with mentioned problem and after --with-spacemacs-icon become available for emacs brew formulae.

P. P. S. Even if you try to install using --with-spacemacs-icon option, emacs will be installed, just without spacemacs icon. Already sent PR to emacs formula. Details in Homebrew/legacy-homebrew#49371.

So not it's recommended to install GNU emacs instead of emacs-mac as
discussed in syl20bnr#4955.
@syl20bnr
Copy link
Owner

We can replace the advice to use emacs-mac-port by the solution to set the variable to nil and explain that it modifies the color rendering of the whole Emacs. Also some users recommend to change the powerline separator to something else not subject to the graphical glitches.

@d12frosted
Copy link
Contributor Author

@syl20bnr as it turned out, brew maintainers are against of adding option for spacemacs icon. So we have an option to create a separate tap for emacs with spacemacs icon. If you wish I can create one.

@syl20bnr
Copy link
Owner

Thank you !

I edited the PR to remove the --spacemacs-icon parameter. I'm not sure we should create a tap, I want people to explicitly install Emacs and then add Spacemacs on top, I don't want to "hide" Emacs and get people confused about what is Spacemacs.
So we could add the steps in the FAQ to add the Spacemacs icon on OS X.

Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Mar 31, 2016
@syl20bnr syl20bnr removed the Merged label Mar 31, 2016
@d12frosted
Copy link
Contributor Author

I want people to explicitly install Emacs and then add Spacemacs on top, I don't want to "hide" Emacs and get people confused about what is Spacemacs.

Good point. People are already confused a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants