Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on auto parens in web mode #8178

Closed
wants to merge 1 commit into from
Closed

Conversation

posva
Copy link

@posva posva commented Jan 15, 2017

I realised this feature was turned off while writing .vue files. Using the web-mode is the (currently) best mode to work and since you write a lot of script, having the smartparens makes it much better:
web-mode-smartparens

@nixmaniack
Copy link
Contributor

It was disabled for a reason I remember. See #4728 for more info.

@posva
Copy link
Author

posva commented Jan 15, 2017

@nixmaniack Hey, thanks for that. I didn't back traced to the issue when I did git blame.
The problem was that typing {{ then space would create an extra closing } like {{ }}}.
I tested that and works fine: it doesn't add any extra } 🎉

@TheBB
Copy link
Collaborator

TheBB commented May 23, 2017

Still breaks it for me. Try opening a .djhtml file and type {% followed by space.

@posva
Copy link
Author

posva commented May 23, 2017

How does it break for you? I tested setting web mode on the scratch buffer and typing {% yields {% }. I thought that was good enough 😄

@TheBB
Copy link
Collaborator

TheBB commented May 23, 2017

Sorry, that's not good enough. Web-mode deals with tons of different templating engines, and {% %} isn't special in all of them. Try running web-mode-set-engine then django first, or open a djhtml file, which will automatically choose the django engine.

@aaronjensen
Copy link
Contributor

Just bit by this. Should web-mode be inserting closing parens? I’m not seeing that happen on typescript-tsx-mode

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this PR is still need merging!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Sep 30, 2020
@github-actions github-actions bot closed this Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants