-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use evil-org from MELPA #9041
Use evil-org from MELPA #9041
Conversation
Seems ok, so I merged it. |
Why remove the |
My reasoning is
For sure, many people will be toggling todo state more often than using the |
I'm strongly against remapping If you're going to be doing a lot of navigation/toggling, you might consider a hydra: (defun org-toggle-element ()
(interactive)
(if (org-at-item-checkbox-p)
(org-toggle-checkbox)
(org-todo)))
(defhydra hydra-org-nav (:exit nil :columns 5)
"Org Navigate"
("h" (org-up-element) "Parent")
("j" (org-forward-element) "Next Sibling")
("k" (org-backward-element) "Previous Sibling")
("l" (org-down-element) "Child")
("t" (org-toggle-element) "Toggle")
("H" (org-promote-subtree) "Promote")
("J" (org-move-subtree-down) "Move Down")
("K" (org-move-subtree-up) "Move Up")
("L" (org-demote-subtree) "Demote")
("q" nil "quit" :exit t)
("d" (org-cut-subtree) "Cut Subtree")
("y" (org-copy-subtree) "Copy Subtree")
("p" (org-paste-subtree) "Copy Subtree"))
(spacemacs/set-leader-keys-for-major-mode 'org-mode
"j" #'hydra-org-nav/body)) |
@Stebalien The text "Copy Subtree" for last key "p", should probably be changed to "Paste Subtree". |
The org-mode todo key has been changed from just: t to: SPC m T T (same as: , T T) in this PR: Use evil-org from MELPA #9041 The PR authors reasons were: >- single-shortcut keys are few in number and valuable >- the vim/evil defaults for those keys are designed for editable modes, and org > is an editable mode >- practically nowhere else in Spacemacs are such keys overridden >- the benefit of making an exception in this case is dubious >- it's not too difficult to configure on a user level > >For sure, many people will be toggling todo state more often than using the t jump operator while in org-mode, but I'm not convinced that this is worth violating POLA in org-mode. But of course if there is consensus that I'm wrong then I'm happy to be convinced otherwise. source: #9041 (comment) - Mentioned that: `t` can be restored for toggling todo, and added a link to the instructions in the org layer documentation: https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode - Rewrote some sentences. - Wrapped some paragraphs at 80 chars.
The org-mode todo key has been changed from just: t to: SPC m T T (same as: , T T) in this PR: Use evil-org from MELPA syl20bnr#9041 The PR authors reasons were: >- single-shortcut keys are few in number and valuable >- the vim/evil defaults for those keys are designed for editable modes, and org > is an editable mode >- practically nowhere else in Spacemacs are such keys overridden >- the benefit of making an exception in this case is dubious >- it's not too difficult to configure on a user level > >For sure, many people will be toggling todo state more often than using the t jump operator while in org-mode, but I'm not convinced that this is worth violating POLA in org-mode. But of course if there is consensus that I'm wrong then I'm happy to be convinced otherwise. source: syl20bnr#9041 (comment) - Mentioned that: `t` can be restored for toggling todo, and added a link to the instructions in the org layer documentation: https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode - Rewrote some sentences. - Wrapped some paragraphs at 80 chars.
The org-mode todo key has been changed from just: t to: SPC m T T (same as: , T T) in this PR: Use evil-org from MELPA syl20bnr#9041 The PR authors reasons were: >- single-shortcut keys are few in number and valuable >- the vim/evil defaults for those keys are designed for editable modes, and org > is an editable mode >- practically nowhere else in Spacemacs are such keys overridden >- the benefit of making an exception in this case is dubious >- it's not too difficult to configure on a user level > >For sure, many people will be toggling todo state more often than using the t jump operator while in org-mode, but I'm not convinced that this is worth violating POLA in org-mode. But of course if there is consensus that I'm wrong then I'm happy to be convinced otherwise. source: syl20bnr#9041 (comment) - Mentioned that: `t` can be restored for toggling todo, and added a link to the instructions in the org layer documentation: https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode - Rewrote some sentences. - Wrapped some paragraphs at 80 chars.
The org-mode todo key has been changed from just: t to: SPC m T T (same as: , T T) in this PR: Use evil-org from MELPA syl20bnr#9041 The PR authors reasons were: >- single-shortcut keys are few in number and valuable >- the vim/evil defaults for those keys are designed for editable modes, and org > is an editable mode >- practically nowhere else in Spacemacs are such keys overridden >- the benefit of making an exception in this case is dubious >- it's not too difficult to configure on a user level > >For sure, many people will be toggling todo state more often than using the t jump operator while in org-mode, but I'm not convinced that this is worth violating POLA in org-mode. But of course if there is consensus that I'm wrong then I'm happy to be convinced otherwise. source: syl20bnr#9041 (comment) - Mentioned that: `t` can be restored for toggling todo, and added a link to the instructions in the org layer documentation: https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode - Rewrote some sentences. - Wrapped some paragraphs at 80 chars.
The org-mode todo key has been changed from just: t to: SPC m T T (same as: , T T) in this PR: Use evil-org from MELPA syl20bnr#9041 The PR authors reasons were: >- single-shortcut keys are few in number and valuable >- the vim/evil defaults for those keys are designed for editable modes, and org > is an editable mode >- practically nowhere else in Spacemacs are such keys overridden >- the benefit of making an exception in this case is dubious >- it's not too difficult to configure on a user level > >For sure, many people will be toggling todo state more often than using the t jump operator while in org-mode, but I'm not convinced that this is worth violating POLA in org-mode. But of course if there is consensus that I'm wrong then I'm happy to be convinced otherwise. source: syl20bnr#9041 (comment) - Mentioned that: `t` can be restored for toggling todo, and added a link to the instructions in the org layer documentation: https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode - Rewrote some sentences. - Wrapped some paragraphs at 80 chars.
Supplants #1417, #9010 and #9011
Evil-org has been heavily overhauled and looks like a much better package now. It has good defaults and is much easier for the end-user to customize. Oh, and it's maintained.
I still removed that silly
t
binding though. :-)cc @Stebalien @dschrempf