Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use evil-org from MELPA #9041

Closed
wants to merge 1 commit into from
Closed

Use evil-org from MELPA #9041

wants to merge 1 commit into from

Conversation

TheBB
Copy link
Collaborator

@TheBB TheBB commented Jun 6, 2017

Supplants #1417, #9010 and #9011

Evil-org has been heavily overhauled and looks like a much better package now. It has good defaults and is much easier for the end-user to customize. Oh, and it's maintained.

I still removed that silly t binding though. :-)

cc @Stebalien @dschrempf

@TheBB
Copy link
Collaborator Author

TheBB commented Jun 8, 2017

Seems ok, so I merged it.

@TheBB TheBB closed this Jun 8, 2017
@TheBB TheBB deleted the evil-org branch June 8, 2017 07:18
@ccaseiro
Copy link

Why remove the t binding?

@TheBB
Copy link
Collaborator Author

TheBB commented Jun 20, 2017

My reasoning is

  • single-shortcut keys are few in number and valuable
  • the vim/evil defaults for those keys are designed for editable modes, and org is an editable mode
  • practically nowhere else in Spacemacs are such keys overridden
  • the benefit of making an exception in this case is dubious
  • it's not too difficult to configure on a user level

For sure, many people will be toggling todo state more often than using the t jump operator while in org-mode, but I'm not convinced that this is worth violating POLA in org-mode. But of course if there is consensus that I'm wrong then I'm happy to be convinced otherwise.

@Stebalien
Copy link
Contributor

I'm strongly against remapping t as I do use it for navigation but, then again, I have SPC free so I just mapped that for toggling (I'm using CapsLock as my leader).

If you're going to be doing a lot of navigation/toggling, you might consider a hydra:

    (defun org-toggle-element ()
      (interactive)
      (if (org-at-item-checkbox-p)
          (org-toggle-checkbox)
        (org-todo)))

    (defhydra hydra-org-nav (:exit nil :columns 5)
      "Org Navigate"

      ("h" (org-up-element) "Parent")
      ("j" (org-forward-element) "Next Sibling")
      ("k" (org-backward-element) "Previous Sibling")
      ("l" (org-down-element) "Child")

      ("t" (org-toggle-element) "Toggle")

      ("H" (org-promote-subtree) "Promote")
      ("J" (org-move-subtree-down) "Move Down")
      ("K" (org-move-subtree-up) "Move Up")
      ("L" (org-demote-subtree) "Demote")

      ("q" nil "quit" :exit t)

      ("d" (org-cut-subtree) "Cut Subtree")
      ("y" (org-copy-subtree) "Copy Subtree")
      ("p" (org-paste-subtree) "Copy Subtree"))

    (spacemacs/set-leader-keys-for-major-mode 'org-mode
      "j" #'hydra-org-nav/body))

@duianto
Copy link
Collaborator

duianto commented Jun 20, 2017

@Stebalien The text "Copy Subtree" for last key "p", should probably be changed to "Paste Subtree".

duianto added a commit that referenced this pull request Nov 9, 2019
The org-mode todo key has been changed from just: t
to: SPC m T T (same as: , T T)
in this PR: Use evil-org from MELPA #9041

The PR authors reasons were:
>- single-shortcut keys are few in number and valuable
>- the vim/evil defaults for those keys are designed for editable modes, and org
>  is an editable mode
>- practically nowhere else in Spacemacs are such keys overridden
>- the benefit of making an exception in this case is dubious
>- it's not too difficult to configure on a user level
>
>For sure, many people will be toggling todo state more often than using the t
jump operator while in org-mode, but I'm not convinced that this is worth
violating POLA in org-mode. But of course if there is consensus that I'm wrong
then I'm happy to be convinced otherwise.

source: #9041 (comment)

- Mentioned that: `t` can be restored for toggling todo, and added a link to the
  instructions in the org layer documentation:
  https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode
- Rewrote some sentences.
- Wrapped some paragraphs at 80 chars.
sei40kr pushed a commit to sei40kr/spacemacs that referenced this pull request Nov 11, 2019
The org-mode todo key has been changed from just: t
to: SPC m T T (same as: , T T)
in this PR: Use evil-org from MELPA syl20bnr#9041

The PR authors reasons were:
>- single-shortcut keys are few in number and valuable
>- the vim/evil defaults for those keys are designed for editable modes, and org
>  is an editable mode
>- practically nowhere else in Spacemacs are such keys overridden
>- the benefit of making an exception in this case is dubious
>- it's not too difficult to configure on a user level
>
>For sure, many people will be toggling todo state more often than using the t
jump operator while in org-mode, but I'm not convinced that this is worth
violating POLA in org-mode. But of course if there is consensus that I'm wrong
then I'm happy to be convinced otherwise.

source: syl20bnr#9041 (comment)

- Mentioned that: `t` can be restored for toggling todo, and added a link to the
  instructions in the org layer documentation:
  https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode
- Rewrote some sentences.
- Wrapped some paragraphs at 80 chars.
fzuellich pushed a commit to fzuellich/spacemacs that referenced this pull request Nov 18, 2019
The org-mode todo key has been changed from just: t
to: SPC m T T (same as: , T T)
in this PR: Use evil-org from MELPA syl20bnr#9041

The PR authors reasons were:
>- single-shortcut keys are few in number and valuable
>- the vim/evil defaults for those keys are designed for editable modes, and org
>  is an editable mode
>- practically nowhere else in Spacemacs are such keys overridden
>- the benefit of making an exception in this case is dubious
>- it's not too difficult to configure on a user level
>
>For sure, many people will be toggling todo state more often than using the t
jump operator while in org-mode, but I'm not convinced that this is worth
violating POLA in org-mode. But of course if there is consensus that I'm wrong
then I'm happy to be convinced otherwise.

source: syl20bnr#9041 (comment)

- Mentioned that: `t` can be restored for toggling todo, and added a link to the
  instructions in the org layer documentation:
  https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode
- Rewrote some sentences.
- Wrapped some paragraphs at 80 chars.
tgroshon pushed a commit to tgroshon/spacemacs that referenced this pull request Nov 22, 2019
The org-mode todo key has been changed from just: t
to: SPC m T T (same as: , T T)
in this PR: Use evil-org from MELPA syl20bnr#9041

The PR authors reasons were:
>- single-shortcut keys are few in number and valuable
>- the vim/evil defaults for those keys are designed for editable modes, and org
>  is an editable mode
>- practically nowhere else in Spacemacs are such keys overridden
>- the benefit of making an exception in this case is dubious
>- it's not too difficult to configure on a user level
>
>For sure, many people will be toggling todo state more often than using the t
jump operator while in org-mode, but I'm not convinced that this is worth
violating POLA in org-mode. But of course if there is consensus that I'm wrong
then I'm happy to be convinced otherwise.

source: syl20bnr#9041 (comment)

- Mentioned that: `t` can be restored for toggling todo, and added a link to the
  instructions in the org layer documentation:
  https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode
- Rewrote some sentences.
- Wrapped some paragraphs at 80 chars.
aam-at pushed a commit to aam-at/spacemacs that referenced this pull request Dec 3, 2019
The org-mode todo key has been changed from just: t
to: SPC m T T (same as: , T T)
in this PR: Use evil-org from MELPA syl20bnr#9041

The PR authors reasons were:
>- single-shortcut keys are few in number and valuable
>- the vim/evil defaults for those keys are designed for editable modes, and org
>  is an editable mode
>- practically nowhere else in Spacemacs are such keys overridden
>- the benefit of making an exception in this case is dubious
>- it's not too difficult to configure on a user level
>
>For sure, many people will be toggling todo state more often than using the t
jump operator while in org-mode, but I'm not convinced that this is worth
violating POLA in org-mode. But of course if there is consensus that I'm wrong
then I'm happy to be convinced otherwise.

source: syl20bnr#9041 (comment)

- Mentioned that: `t` can be restored for toggling todo, and added a link to the
  instructions in the org layer documentation:
  https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bemacs/org/README.org#org-with-evil-org-mode
- Rewrote some sentences.
- Wrapped some paragraphs at 80 chars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants