fix: ensure hash function is available #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 72.94% 73.01% +0.06%
==========================================
Files 35 35
Lines 2953 2953
==========================================
+ Hits 2154 2156 +2
+ Misses 644 642 -2
Partials 155 155
|
Rather than using crypto.SHA256.New(), use sha256.New() directly to ensure the SHA256 algorithm is available.
dtrudg
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
sha256.New()rather thancrypto.SHA256.New()to ensure the SHA256 algorithm is available (avoids "requested hash function is unavailable" panic in #313.) Improve tests foraddof OCI index/blob.Fixes #313