Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary nolint:errorlint lines #321

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

tri-adam
Copy link
Member

As of v1.4.4, go-errorlint exempts Is methods from type assertions (see polyfloyd/go-errorlint#50).

As of v1.4.4, go-errorlint exempts `Is` methods from type assertions
(see polyfloyd/go-errorlint#50).
@tri-adam tri-adam self-assigned this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #321 (b3b7b9f) into main (5b349c4) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   73.01%   73.03%   +0.02%     
==========================================
  Files          35       35              
  Lines        2953     2948       -5     
==========================================
- Hits         2156     2153       -3     
+ Misses        642      640       -2     
  Partials      155      155              
Files Changed Coverage Δ
pkg/integrity/metadata.go 58.51% <ø> (+0.85%) ⬆️
pkg/integrity/select.go 75.21% <ø> (-0.22%) ⬇️
pkg/integrity/verify.go 80.00% <ø> (-0.06%) ⬇️
pkg/sif/descriptor_input.go 86.88% <ø> (-0.08%) ⬇️

@tri-adam tri-adam marked this pull request as ready for review August 22, 2023 14:16
@tri-adam tri-adam merged commit ef68a1d into sylabs:main Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants